Build Failed with Gradle 6.6 about dart HOT 10 OPEN

@markchristopherng yes just run ./gradlew henson-pluigin:assemble on my fork and copy the jar.

from dart.

@markchristopherng the problem now, if you enable gradle configuration cache generateHensonNavigator task will fail your build. Do you have plan to use gradle config cache ?

Currently we don't use the gradle config cache

from dart.

It can be fix when change the parameter type: https://github.com/f2prateek/dart/pull/244/files

But it will need to build using gradle 6.6.1. Use 6.6.1 on henson-plugin module works, but i got another issue with test failed on dart-processor module.

from dart.

So the test of dart-processor will failed if using gradle 5 or above.

After debugging one by one here few things i found:

1. It happen after using gradle 5 (from 4.10.3)
2. Dart not generating binder field if class parent from outside class.
3. https://github.com/f2prateek/dart/blob/master/dart-common/src/main/java/dart/common/util/NavigationModelBindingTargetUtil.java#L113 this one return null even with the same parameter on gradle 5 and above, while it return correct type on 4.10.3.

Any idea why it is return null on different gradle version ??

from dart.

Seems https://github.com/f2prateek/dart/blob/master/dart-common/src/main/java/dart/common/util/NavigationModelBindingTargetUtil.java#L113 is null because the binder not generated so the element cannot find it

This one not generated in gradle 5 and above.
dart.processor.data.ActivityWithNavigationModelField__NavigationModelBinder

from dart.

Seems it is because gradle 5 ignore annotation processor on compile class path. So we need to specify annotation processor path.

However i don't find a way to add annotation processor path from a class on the same module. So i move all test from dart-processor into a new module, and consume the dart-processor using this way:

tasks.withType(JavaCompile) {
options.annotationProcessorPath = configurations.annotationProcessor
}
dependencies{
...
annotationProcessor project(':dart-processor')
}

from dart.

So can we update this library to gradle 6 above ?

from dart.

Hi @doniwinata0309 does your PR fix this issue? Just wondering if i now i have to build my own version of this library just to get past this issue.

from dart.

I built the PR and it fixes the issue and it works with Gradle 6.7 which got release last week

from dart.

@markchristopherng the problem now, if you enable gradle configuration cache generateHensonNavigator task will fail your build. Do you have plan to use gradle config cache ?

from dart.