f4z3r / gruvbox-material.nvim Goto Github PK

The background in the number column in is not correct for gitgutter and signs when using the hard or soft contrasts of the colorscheme.

I prefer to use the hard contrast, but I have no idea how to change it, and I didnt see anything in the readme about it.

Highlighting does not work with transparent background while in visual mode, No highlighting is shown and works fine if the background is not transparent.

Hi @f4z3r ,

First off, great work on this project. You were definitely the right person to fork the plugin! It has been exciting to see the progress.

However, I discovered a change in behavior after the large refactor commit: 16f937c. Starting with this commit, the statusbar is populated with the "^" fill character (see :help fillchars for more info).

I am not sure what exactly caused this change. I landed upon this commit by doing a git bisect. I plan to investigate more in the coming days.

Screenshots

There have been breaking changes to treesitter captures: nvim-treesitter/nvim-treesitter#2293

Since then the highlighting of Markdown for instance no longer works.

Port from WIttyJudge/gruvbox-material.nvim#3

Hi @f4z3r,

I use auto-dark-mode to change my neovim background to dark or light depending on my machine settings.
This behavior was not being reflected within the gruvbox-material palette. The palette would be calculated only at the initial loading stage of the plugin and not anymore.
Commenting these lines out:

Solves the issue. Changing the background manually or via the auto-dark-mode plugin, effectively changes the color palette as expected.
Is there a reason on why this check exists? Or can it be safely removed?

Hi!
I was going to try to open a PR to enable this functionality, but i have 0 Lua experience and couldn't get the job done.
The option to be able to override some highlights is really nice, and the way other plugins achieve it seem pretty simple, although I do not really know how to approach this problem.

Note:
While on this topic of overriding, this came about because of the usage of the color blue for the variables and text. This does not seem like the intended behavior, and while investigating WIttyJudge's highlight definitions, I see that with the old Treesitter's highlight groups, he linked TSVariable = { link = 'Fg' }. With the new groups, becomes: TSVariable -> ["@variable"], and this colorscheme defines: ["@variable"] = { link = "Blue" }. Isn't this an error?

The current highlight group for yanking is red I would love if wither we hve the option for changing it or it is changed on dark to be something else.
Personally I like the colour #a9b665 for it

Backgroundtransparency does not seem to work

vim.g.gruvbox_material_transparent_background = 1

Is set and doesnt seem to work

The spelling highlighting is the sme colour as the text

Refactor the configuration of the plugin to use parameters to the setup function instead of globals.