fabarea / media Goto Github PK

Hi,

we had the problem in a project that the admins could find all files via the search in the media module, but the other user groups couldn't.
Those files could be found with the normal file list. After opening the files there once, there also appeared in the search results in the media module.
These files also don't have any access restrictions.

Could this be solveable by running the indexing task?
Or is this problem related to something else?

Thanks,
Sebastian

In current master (vidi and media) - at least with PHP 5.4 - users filemounts are not respected. If a user has a filemount he can see the whole storage. Constraints are passed by signalSlot to

protected function respectFileMounts(Query $query, $constraints) ...

and in the end happens this:

$constraints = $query->logicalAnd(
    $constraints,
    $constraintsRespectingFileMounts
);

This wont work, at least in PHP 5.4. The $constraints variable is not modified in any way.

Goal is to avoid a wrong message in the Media module.

The "data-uid" is missing in the anchor-tag (renderAnchorTag()) for audio and video files.
Following a patch file content to solve this issue:

Index: AudioThumbnailProcessor.php
--- AudioThumbnailProcessor.php Base (BASE)
+++ AudioThumbnailProcessor.php Locally Modified (Based On LOCAL)
@@ -96,10 +96,11 @@

        $file = $this->getFile();

-       return sprintf('<a href="%s%s" target="%s">%s</a>',
+       return sprintf('<a href="%s%s" target="%s" data-uid="%s">%s</a>',
            $this->thumbnailService->getAnchorUri() ? $this->thumbnailService->getAnchorUri() : $file->getPublicUrl(TRUE),
            $this->thumbnailService->getAppendTimeStamp() ? '?' . $file->getProperty('tstamp') : '',
            $this->thumbnailService->getTarget(),
+           $file->getUid(),
            $result
        );
    }
Index: VideoThumbnailProcessor.php
--- VideoThumbnailProcessor.php Base (BASE)
+++ VideoThumbnailProcessor.php Locally Modified (Based On LOCAL)
@@ -97,10 +97,11 @@

        $file = $this->getFile();

-       return sprintf('<a href="%s%s" target="%s">%s</a>',
+       return sprintf('<a href="%s%s" target="%s" data-uid="%s">%s</a>',
            $this->thumbnailService->getAnchorUri() ? $this->thumbnailService->getAnchorUri() : $file->getPublicUrl(TRUE),
            $this->thumbnailService->getAppendTimeStamp() ? '?' . $file->getProperty('tstamp') : '',
            $this->thumbnailService->getTarget(),
+           $file->getUid(),
            $result
        );
    }

When the User selects a folder from the tree, the upload should ends up in this particular folder.

I tried to enable sorting by "Title" by modifying the TCA with this snippet:

$GLOBALS['TCA']['sys_file']['grid']['columns']['metadata.title']['sortable'] = TRUE;

The sorting arrows are now shown for the field "Title", but clicking on the arrows leads to a error 500 because of this wrong sql query:

SELECT DISTINCT
    sys_file.*
FROM
    sys_file
    LEFT JOIN
    sys_file_storage
    ON
        sys_file.storage=sys_file_storage.uid
        AND
        sys_file_storage.deleted=0
WHERE
    sys_file_storage.uid = '1'
ORDER BY
    sys_file_metadata.title
    ASC
LIMIT
    10

This exception is thrown:

#1247602160: Unknown column 'sys_file_metadata.title' in 'order clause': SELECT DISTINCT sys_file.* FROM sys_file LEFT JOIN sys_file_storage ON sys_file.storage=sys_file_storage.uid AND sys_file_storage.deleted=0 WHERE sys_file_storage.uid = '1' ORDER BY sys_file_metadata.title ASC LIMIT 10

TSConfig:

options.folderTree.altElementBrowserMountPoints = 1:/, 2:/test

• Edit and delete icon should be hidden
• Perhaps display it in a special way (light gray) in the Grid?

Scenario: As I user, I want to find all files with Usage 0 and delete them.
The permission stuff should be implemented in a reusable way (kind of service)

There currently is a pending patch for Vidi to drag & drop rows for sorting records. Take over this patch.

Do not limit browsing of files to the selected directory only but add an option (like a checkbox) whether to include sub-directories.

Two Hooks in the media ext. use the method

$refIndexObj->updateRefIndexTable($tableName, $id);

from the core in hooks and make strong constraints that its response is an array. But since TYPO3 6.2.11 it can also be boolean (FALSE). As a result saving a document with FAL relations can lead to a fatal error if no relations were found.

The method is used in Classes/Hook/DataHandlerHook.php in lines 72 and 99. Adding a simple

if (FALSE === $indexes) $indexes = array();

solves the issue but I think the real issue is in the core.

Hi,

are there any plans for a version working with TYPO3 CMS 7? Maybe I can help a little bit.

Markus

I cant find a permission constellation on a group to allow users the categories in media extensions.
If a image is uploaded and the metadata edited the categoires tab does not show.

BE Group for that users have , mount on some categories, has read and modify table categories for that matter.

As an admin there is no problem, the form displays and working just fine.

Display the folder tree and filter by mount point.

This feature must be activated in the Extension Manager.

Improve usability:

• Omit checkboxes for files that have references and thus cannot be deleted
• Improve wording
• Add a toogle check button

AFAIK the only possibility to search by title or by description only is to use these search instruction:

metadata.title:foo

metadata.description:bar

IMHO this is not very intuitive. Editors will most probably try these two search instructions to filter by title or description:

title:foo

description:bar

Currently the tools (Duplicate finder etc.) are not translateable because the texts are not in an XLF file. This should be changed.

I'm just filing this report here to keep track and will pick it up to do it as soon as I have time.

Add limit when generating thumbnails more or less the same way the Core does for salted passwords. Generating thumbnails is very consuming resource wise. Goal is to avoid monopolizing the CPU too long.

Check if possible to configure the module to hide the tree for basic Editor users for instance. Reduce visual "complexity". I don't know if that's possible without changing the Core.

Replace file does not work for remote storages.

The creation of file references to existing files does not work if not logged in as 'admin'.
An "Access Denied" error is thrown when i try to add a file to "related_files" as a normal BE user.
I created a user group with all rights except 'admin' and it does not work.
Maybe anybody can reproduce this behavior?

Somehow some files (not all) in an installation are displaying in search results for a search for files with "Usage: 0" even if they have references. The search term seems to be correct, and the number_of_references column in sys_file is correct, too:

While using media within normal images I can select an image by clicking on it or choosing the row action. When I try to do the same within the RTE integration I get the image edit mode, where I can crop the image. I'm unable to select the image. Also I don't have the ability to choose several images and use the row action method.

Reproduction

1. In the Media selection Add Video e.g. (Content -> FCE -> Video)
2. click on preview icon => error
3. click edit image (label/title is wrong) => success

Uncaught TYPO3 Exception
#1300096564: uid of file has to be numeric. (More information)

InvalidArgumentException thrown in file
typo3/sysext/core/Classes/Resource/ResourceFactory.php in line 340.

8 TYPO3\CMS\Core\Resource\ResourceFactory::getFileObject("undefined")

Allow the User to filter by writable files. This would be convenient for mass actions such as mass-delete which is only allowed for "writable" files.

When you create a content element with images in draft workspace (i.e. other than live workspace), then you try to update it - you end up with whitescreen.
Following exception occurs:
Argument 1 passed to TYPO3\CMS\Media\Hook\DataHandlerHook::isSoftReferenceImage() must be of the type array, boolean given, called in .../typo3conf/ext/media/Classes/Hook/DataHandlerHook.php on line 205 and defined.

\Exception('I could not find a valid file identifier', 1392926871);

That's because "safe-and-new" will create a new filemetadata-record but there is no "file" yet set.

When i'm relating a new or existing image to my contentelement, but first edit some metadata using the "Edit Metadata"-link inside the popup, the icon to relate the image disappears when i'm returning to the grid/list.

Is this a know issue? Is there a way to make it work ?

The doc header should gain more buttons like the file list module (e.g to create new folders)

When the user is in a workspace and saves a Text & Images CE, on saving a fatal error occurs:

[Tue May 19 15:55:34 2015] [error] [client 127.0.0.1] PHP Catchable fatal error:  Argument 1 passed to TYPO3\\CMS\\Media\\Hook\\DataHandlerHook::isSoftReferenceImage() must be of the type array, boolean given, called in /home/www-data/www/htdocs/typo3conf/ext/media/Classes/Hook/DataHandlerHook.php on line 215 and defined in /home/www-data/www/htdocs/typo3conf/ext/media/Classes/Hook/DataHandlerHook.php on line 248, referer: https://www.domain.tld/typo3/alt_doc.php?returnUrl=%2Ftypo3%2Fsysext%2Fcms%2Flayout%2Fdb_layout.php%3Fid%3D531&edit[tt_content][33122]=edit

Didn't have time to check it yet, but I will.

The select-image button in the popup has the incorrect title "Edit image" - see the screenshot.