fabd / diablo2-runewizard Goto Github PK

Here it is

Currently searching sword does not match runewords with generic Melee Weapons as a weapon type.

It would be nice for a weapon class search term to match runewords with "Melee Weapons", "Missile Weapons".

Implementation?

While matching the search term with weapon type, somehow "Melee Weapons" or "Weapons" needs to be an alias for the possible weapon types to match against.

Change the mouseover events for the runeword popup as mousenter/mouseleave doesn't seem to work with touch on tablet.

Responsive layout is not important for this app, but being able to see the popup with a touch input would be better.

Fix please:

Tal 17
Thul 23
Ort 21
Amn 25

For example Spirit's 7% Life Stolen Per Hit comes from Amn (when socketed into a weapon (Swords).

We could display [Amn] next to the mod, or the icon (though it's not easy to remember rune names from the icons alone).

The best way to do this of course would be to derive all that data from datafiles; but that's a lot of work that's perhaps not warranted at this point.

A simpler way could be to just add [Amn] in the runeword description; and style these accordingly. Perhaps support basic markdown to format the runeword text.

Since users can play the game in many languages ad we won't realistically suport languages in this simple app, it could make sense to add UX in the form of tags for common searches under the search bar.

• makes search by weapon type/etc obvious to users
• match common search terms : weapons, armors, swords;, axes etc.

...

Search [ __________________________________ ] 
( axes ) ( bows ) ( swords ) ( missile weapons ) ...

• design some tags under search bar ( FIGMA )
• chose a small but common set of tags, display under search bar
• apply highlighted style to active tag(s)
• tags should probably be exclusive (if one is clicked, un-select the other ones)

Add package lock file to fix the usual shenanigans with npm packages.

Try some tools that generate favicon.

Hi @fabd !

First of all, thank you for your work, it has been incredibly useful and i'm very grateful for your endeavor!

Here with Season 6 of PD2 coming up this Friday (Nov 25th), i'm trying to have this thing up and running (yet again :D). Due to my limited knowledge (i can read html / css, but have no clue about JS), i cannot understand why my github pages are failing to load.

In my fork i've updated Main branch with all the new and changed runeword-descriptions, runewords, item types. Changed a few things elsewhere to reflect PD2. In the gh-pages branch i synched it with yours, tried to do few updates to see if pages will work, but they don't. https://kvothed2.github.io/pd2-runewizard/
It is failing to load resource /src/main.ts
I tried to launch it from the gh-pages /root and /docs (no idea about this tho) and from main /root

If this is something you can help me with easily, i would be forever grateful.
Thank you very much.
KvotheD

Avoid clipping the popup, particularly if user has zoom level > 100% in the browser.

Possible implementation:

• make the popup fixed position, always center and top of the viewport -- regardless of page scroll
• (optional) make the header also fixed so it stays on the page (would look nicer I think once the popup is "stuck" to the top edge, makes the top area less empty looking)

Hello, Leaf is defined as :
{ title: "Leaf", runes: ["Tir", "Ral"], level: 19, ttypes: ["Staves"], tinfos: "(Not Orbs/Wands)", },

with text "(Not Orbs/Wands)"

and Memory is defined as :
{ title: "Memory", runes: ["Lum", "Io", "Sol", "Eth"], level: 37, ttypes: ["Staves"], tinfos: "(Not Orbs)", },

with text "(Not Orbs)".

But it looks like Memory can't be inserted into a wand either as this runeword requires a 4 slotted staff.

In D2R you can make all the old ladder only runewords in non-ladder or singleplayer. I just made an insight for example and I don't play ladder. Only the new 2.4 runewords are ladder only.

Simple fix by designing a footer to fill some verttical space at bottom of page

And/or do something more fancy to compute the popup height and move it