Docs: Add ctrl + k hotkey for search to enable searching on windows (cmd is reserved) about valibot HOT 10 CLOSED

Thanks for the hint. Unfortunately, I can't implement it at the moment. Our current Qwik version does not allow us to call event.preventDefault() in a fine-grained way. We can only call it for every keydown event, and that breaks the website. I will have to upgrade to the latest Qwik version first, but that will take a few weeks because other things are more important at the moment.

from valibot.

Ah, I see you are using the meta key that only works on mac, on windows the meta key is reserved for some windows popup, on windows it's common to use ctrl instead, I have implemented it like this (for different website):

	function keydownHandler(event: KeyboardEvent) {
		if (event.key !== 'k' || !(event.ctrlKey || event.metaKey)) {
	            return;
		}
		event.preventDefault();
                searchDialog.open();
	}

Now both ctrl + k and cmd + k work, assuming you don't have ctrl + k reserved for anything else this should do the trick.

from valibot.

I've edited the issue to be more accurate (I wasn't aware it was already implemented at the time of creating the issue)

from valibot.

@fabian-hiller Just checked, all works properly now, thanks!

from valibot.

This should be implemented already. Does it not work for you? It works for me. Here is the source code: https://github.com/fabian-hiller/valibot/blob/v0.28.1/website/src/components/DocSearch.tsx#L291

from valibot.

Thank you for creating this issue! I will investigate and fix this!

from valibot.

Awesome, thank you for the quick response!

from valibot.

Can you check if it works on Windows now?

from valibot.

It works but you need to prevent the default, otherwise the browser will bring focus to the search bar:

from valibot.

@Hugos68 can you check if this is fixed now?

from valibot.