The avatar-duel-01 from fabianzhafran

Package structuring

Using gradle, usually the files are organized in src/main/java/com/avatarduel/ and have package prefix com.avatarduel.

This issue is only a suggestion. You may argue with it (not all the suggestions are true), challenge it, or come up with another idea yourself. Please kindly close this issu after you feel this issue is irrelevant / solved.

Inconsistent Language

Better to have a consistent language in your code. Etiher they all Bahasa, or English.

avatar-duel-01/src/Kartu/SummonedCharacter.java

Lines 1 to 3 in c0a9678

 class SummonedCharacter implements ISummoned { 

 Karakter karakter;

This issue is only a suggestion. You may argue with it (not all the suggestions are true), challenge it, or come up with another idea yourself. Please kindly close this issu after you feel this issue is irrelevant / solved.

Using super on child class constructor

Maybe you can consider using super()

avatar-duel-01/src/main/java/com/avatarduel/Card/Aura.java

Lines 9 to 16 in 872c7ea

 public Aura(String name, Element elemen, String desc, String path, int pow, int atk, int def) { 

 this.name = name; 

 this.element = element; 

 this.description = desc; 

 this.pathGambar = path; 

 this.attack = atk; 

 this.defense = def; 

 this.power = pow;

This issue is only a suggestion. You may argue with it (not all the suggestions are true), challenge it, or come up with another idea yourself. Please kindly close this issu after you feel this issue is irrelevant / solved.

fabianzhafran / avatar-duel-01 Goto Github PK

avatar-duel-01's People

Contributors

Stargazers

Watchers

avatar-duel-01's Issues

Package structuring

Inconsistent Language

Using super on child class constructor

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	class SummonedCharacter implements ISummoned {

	Karakter karakter;

	public Aura(String name, Element elemen, String desc, String path, int pow, int atk, int def) {
	this.name = name;
	this.element = element;
	this.description = desc;
	this.pathGambar = path;
	this.attack = atk;
	this.defense = def;
	this.power = pow;