fabienhenon / bs-remotedata Goto Github PK

In the WebData module, handleJsonDecode's type signature doesn't suggest that it has to be used with bs-json, but the body of the function is very bs-json-specific (expecting the decode function to potentially raise Json.Decode exceptions). These couple lines of code make this lib depend on bs-json, and make WebData difficult or impossible to use with other JSON-decoding libraries.

Locally I've changed the signature of the decoder function from Js.Json.t => 'a to Js.Json.t => Belt.Result.t('a, string). This allows it to be used with other decoder libraries. It can still be used with bs-json, but it requires the user of bs-json to convert exceptions into Belt.Result.Errors, which feels like a fair compromise.

If you're open to this approach, I'm happy to open a PR with my change. I should mention I'm biased because I'd like to be able to use bs-remotedata with the json decoder library I'm maintaining, which uses Result instead of exceptions.