Should we delete the "custom HMR" ? about fable.lit HOT 3 CLOSED

Yes, indeed it would be ideal to have a common Elmish.HMR (Fable.Lit will still keep some specific HMR code but that's unrelated to Elmish).

That's fine to me as this is specific to Fable.Lit

Elmish.Browser (though it'd be nice to remove the dependency if we had termination capabilities)

I think that when we have termination capabilities it should be able to remove the old listener.

Another possibility would be to add this code directly to Elmish.React with #if DEBUG as it only checks a global variable so it doesn't even need a dependency on Elmish.HMR.

This code also checks if there is the HMR modules presents.

In the past Eugene said he didn't want to have any code specific to HMR in the main modules. I think this is both to keep the code simple and also because he can't assure to be able to maintain it.

I am only able to maintain HMR because I invested a lot of time initially in it and even today it requires a lot of works to make it works correctly.

We can try to ask Eugene opinion on it today.

The ideal scenario would be:

1. Having Fable.Elmish.Browser use termination feature to clean itself
2. Fable.Elmish.React check for the global variable and wrap the HMR code inside a #if DEBUG directive
3. Make Fable.Elmish.HMR dependant on Fable.Elmish elmish allowing it be used in Fable.Lit.Elmish, Fable.Snabbom.Elmish, Fable.Elmish

from fable.lit.

I removed HMR from Lit.Elmish 1.4. We'll live with the React dependency for now :)

from fable.lit.

Yes, indeed it would be ideal to have a common Elmish.HMR (Fable.Lit will still keep some specific HMR code but that's unrelated to Elmish).

The main issue, as you said, are Elmish.HMR dependencies, particularly Fable.React and to a lesser extent Elmish.Browser (though it'd be nice to remove the dependency if we had termination capabilities). We can break Elmish.HMR into Elmish.HMR/Elmish.HMR.React but this means React users will have to install an extra package to make it work. Another possibility would be to add this code directly to Elmish.React with #if DEBUG as it only checks a global variable so it doesn't even need a dependency on Elmish.HMR.

from fable.lit.