fack1 / countries-autocomplete Goto Github PK

• create event listener for search input

• Build index.html
• Build style.css
• Add images

very good job

Where are your tests?

You should display the selected country inside search input after the user choose it

The response should be with the matched country, not all countries!

You should filter the json file and return the matched country

here

• is the syntax here correct? (@@media)
• why do you have a media query for min-width: 200px? Are any screens smaller than that?

• Fill the array of countries

host app on heroku

test title !

Endpoints should be inside router file

• Homepage endpoint: get the index.html file
• style/images endpoint: get the style.css, main.js and images
• 404 endpoint: get error response ( Page Not Found )
• AutoComplete endpoint related #7

In line 22, and line 26, is it the same variable? If so, why did you re-declare it with a new name (item)?

In this line, are you appending the div as a child of input?

• read countries.json file
• get data from countries.json file
• function to get name of country depend on type each letter
• response data (matched countries)

• listen to search input
• function to get data from search input by each letter
• send data to handler function that realated to AutoComplete function

If I try to write a letter inside the search input, I can't click on any place of your website then

• public Folder

• main.js
• index.html
• style.css
• images folder

• src Folder

  • handlers.js
  • router.js
  • server.js
  • countries.json related #4

• .gitignore related #5

• package.json

this function is brittle!

see here, you write:

document.getElementsByTagName('DIV')[1].remove()

• Is there relevance to it being DIV and not div?
• What if later someone adds another div or DIV tag to the page?

The right way to console.log afrer the the server is start running is by passing the console console.log function in the optinal callback parameter of server.listen as following:

 server.listen(PORT,()=>{ 
 console.log(`server up and running on port ${PORT}!`) 
})

there is no test for the code

<meta name="viewport" content="width=device-width, initial-scale=1.0">

• skip the node modules folder when uploading our website on github

• the title not clear and easy to read .
• beautiful beackground ^_^