fack1 / fid-sh-had-week8 Goto Github PK

here:

you catch then immediately throw the error? Why? if this isn't dealt with elsewhere it will crash your server. You should never throw an error without catching a dealing with it elsewhere, and normally in the same file (if this error is being caught elsewhere at the moment, maybe you will refactor a different file and forget about this error and break your app).

You should pass it on to your error handler by calling next(err)

• Home page GET /
  • Response should render html home page
• Search function GET /search
  • Get data by search value from request
  • Call getData() query from database folder
  • Response should be rendering result to search.hbs file
  • Data should be manipulate inside search.hbs file
• Login function POST /login
  • Get username and password from request
  • Call getUser() query from database
  • Validate if username and password already exists
  • SetCookies for the user
  • Response should be redirect to profile.hbs
• Add Tutorials POST /addTutorials
  -Get username value , language name value , link value from request
  -Post username , language name , link by addData() query to database
• signup function POST /signup
  • Get username, email and password from request
  • Call postUser() query from database
  • Validate if username and password already exists, if not add user
  • Response should be redirect to home.hbs
• Handle errors
  • page not found if status code = 404
  • server error if status code = 500

• home
• search
• signup
• errors
• partials
• header
• layouts
• main

do you have a form validation?

may that can be helpful

for URL validation check link: Joi.string().uri().trim().required()

I think here:

Result isn't the best name, maybe instead tutorialsArray or something

• write test for router

Hi,

Just had a look and the path for your lint script is wrong:

I think you don't want to go into the server folder?

Also eslint won't work without a config file.

I suggest on a new branch quickly:

1. change your lint script path
2. run eslint --init and choose the airbnb style guide
3. run npm run lint to see lint problems
4. runnpm run lint-fix and manually fix any other problems
5. put in a PR and get it merged ASAP

Here:

Not a huge fan of this to be honest, if you are going to do it, do it consistently - especially for something like parse which could mean anything. I would just require cookie and do cookie.parse when you need it, it will be neater

User name: admin,

make it unique once you write the tables to avoid writing query for checkuser before inserting a new user
unique will not allow using the same email again for another user!

• db_build.sql
• db_build.js
• db_connection.js
• queries
• getData
• postData

need to remove the insert query in db_build.sql
manual added users cant be logged in on the server bcz of hashing the pw

its not working as before for some reason!

creating server files with express

you have a good readme

I think you need some information for the user on what they can search for. If it's HTML then mention it somewhere ❤️

I would also try to make lowercase 'html' work too.

I'm unable to add new tutorials at the mo. This may be due to the way you're parsing your body, there's this line missing in your app.js: app.use(express.json()) (which works the same as 'bodyParser'). Also see @m4v15's issue #41.

• ClientValidation
• ServerValidation

npm run dev doesn't work as there are two declarations of router. See below:

all hbs files

Here:

You should do something more useful than console log. Maybe render 500? Not sure.

It's awesome you have error handling here but the json error coming back may scare users.

Adding a error message could be done the same way as this:

Add Tutorials POST /addTutorials
-Get username value , language name value , link value from request
-Post username , language name , link by addData() query to database

All of this:

Is hard to read. You should seperate out the requires into logical groups:

• npm modules
• validation files
• controller files

The password field should always be hidden! Check out this line:

Here:

It's not exactly a problem, but it's a bit messy and you shouldn't need to do it - once it's been required once, everything in config.env will be available to your entire app.

However, the difficulty is in making sure the file where it is required happens before the other files where they need the variables (especially in much bigger apps).

Common practice is to have a config.js file that does all this requiring, and to call it from server.js where you start you server.

See this example (first file is the start.js, what you call server.js and the second file is the config.js - here the dotenv module does the same as what env2 does:

https://github.com/foundersandcoders/open-tourism-platform/blob/master/src/start.js

https://github.com/foundersandcoders/open-tourism-platform/blob/master/config.js