fack1 / foodrecipes Goto Github PK

Have you forgot to pass the request and response object to the error handler given the request have failed to get a response.

initializing npm "package.json"

call errorHandler() when request url is not defined .

call the getRecipes-handler when the url is /search/getRecipe?id=[Recipeid]

on both localhost & herokuapp

why does your lint script only look inside src/server?

You have a website with likeable on design and on work. You need more work in style to be more response.

Other one, it must be have a "Maklobe" 😅

Add css code to the file, to make the site better and responsive.

good tests in general!

a couple of comments about the public handler tests:

• could you also test other files than the index.html? The index file is actually served from the home route in your app.
• Also, could you test the content of the response as well as the status code and content type?

Should create server.js file that runs the server and listening to the assigned PORT.

• https://github.com/FACK1/FoodRecipes#about
• your project dose not for Recipes just for food it self .

Update index.html file to be used by client-side when he request it.

when the request access to the server and the url is / the response is index.html

Should update dom file to make changes into the index.html file.

Create tests to test functions locally and using Travis online.

Update router() to call the publicHandler() when the url request is "/[filePath.extention]" and the file is exists in the public folder.

Show results using good template.

• all tests about status code
• no test to result
  https://github.com/FACK1/FoodRecipes/blob/master/src/test/test.js

• should not uplode .env file with your project

Add css resets to the file, to use it as defaults on all the browsers.

In all of your tests this line is unneeded. Do you know why?

Define errorHandler() function, When the router request url is not exists in the router, it will call this function to return error-response.

call the searchRecipes- handler when the url is /search?value=[searchValue]

create an endpoint that take search to recipes

• .env
• public
  1-js (request.js && dom.js)
  2-css( requests.css && index.css)
  3-index.html
  *src
  1- server (server.js &&router.js && handler)
  2-test (test.js)
  3- search Recipes(searchRecipes.js)

Great job with the desktop design! A few pointers:

1. Responsiveness: To add to Ameen's point #37, the mobile design structure can be improved. For future projects it's easier to start with the mobile design and then create the desktop design as you don't have to squeeze everything from a big to a small screen.

2. Colour scheme: I think the dark gray boxes for results could be softened by picking a lighter gray.

3: Food images: You've picked a great API, the images are really high quality. It would be great if they were made even bigger to fit the whole container. For example:

4. Opacity of the background: I think the background image is great but the opacity is too low.

Define function in router.js to call the homeHandler() function when the request url is '/'.

handle public & API requests

install required npm libraries: eslint, tape, tap-spec, nodemon, dotenv, request.

You shouldn't share your API key or make it public, the point why you have created the .env file and one main benefit of sending APIrequests from the back-end is to hide the API key.

Instead of adding it in the instruction to use the add, you should have said go to https://www.food2fork.com/ and generate an API key...

Please change the readme instruction to use the app accordingly.

Add files to ignore it.

create a handler that get the recipes from the API