fack1 / mass Goto Github PK

• Header
• Form
• To do list

• create main section in design ( index.html)

the websit very god and the Design very nice

copy files from here

Should remove skeleton folder with all files init, because it's an empty files.

Update Dom File to be able to make it's tasks.

Fix deleteTodo function in the logic.js file.

button sort not work

Test Coverage should be 100%, can use Istanbul test coverage tool.

The user can add an empty todo, which doesn't seem to be useful!

I checked your accessibility on Google Chrome's developer tools and it scored on 51%. So maybe check that out? I just wanted to grab your attention to it, that's all :)

• Make tests to test these:
• Add to-do takes two arguments, a to-do array and a to-do element
• it should return a new array
• the arguments should not be mutated

Hey there, I think you did a wonderful job. Seriously I really love your site, everything about it is simple yet cool.

Anyways, here are my suggestions:

1- After a user (adds) enters a to do, I think it would be cool if you cleared the field automatically so the user can enter a new one comfortably instead of clearing it again.
2- It would be also cool if you made it more visible when a user is trying to edit one of the todos. At first I really thought it wasn't working til I directly clicked on it and tried to edit it myself. I think you can achieve that by maybe making the input edit field bigger? Idk just a suggestion.

its matched and very nice

To add stuff to the DOM

good job on adding coverage! You shouldn't commit the generated coverage folder though.

most of the comments should be removed! The only comments which you need are those which clarify your code.

for example:
here, here, here...

fix sortTodo function in logic.js file.

See here

I have absolutely no idea what this code is doing when I try to read it 😄

How you could improve it:

• better variable names
• more/better comments

website accessibility is 51%, should be 100%. :)

your markTodo function is never used in your app!

good job on implementing the edit!

I think an improvement would be: when you click edit, the user can start typing immediately, instead of having to click on the text.

• Write tests
• function to mark todo