Nice work on raising issues to do some work, and on bugs you noticed.

One thing I would do though, is once the task/problem raised in the issue has been done, then the person who opened the issue should close it

It's best practice to always put a link to the website or app in the read me file, so developers can easily look at it.

users menu ready but not responsive

users issue

Your site has two different font's, which can look a bit odd sometimes.

I think looking at the code, you never set a global font, so most of the text just uses the default browser font - you should always specify the font, probably in the body css class

final work

Body
Nav
Basic Section
Footer

Great that you guys have some really nice responsive stuff going on. However at the moment the site still looks a bit weird on mobiles:

The problem is because you need a meta tag in your html to tell the browser to check for the viewing device screen size - read more here

If you add the meta tag, your site becomes more responsive.

You repeated the line of code that's linking to the Osky.css file, and it's considered bad practice to repeat lines of code. Also, you have used it in the body-header which is wrong because everything in the body is displayed to the user and all links and relevant info for the browser should be placed in the head only.

Rather than have your files named oSky.[ext] best practice is to stick to names that describe the content of the files somewhat - index.html is always known as the file that will store the main content. Then you can have either a styles.css to store the styles, or maybe an index.css. Then if you have other specific css files for something it could be animations.css or something. For JS, again, index.js is good, or else a name saying what the code does

• i didn't find adressing each section a favorable thing, while they have the same thing in the header
• instead of using images for contact section they could use https://fontawesome.com/icons?d=gallery for sites symbols
• & i liked the map idea and their represented pic

I commented out this javascript and it didn't seem to change anything on the page. Looks like it would do something if this line is commented out:

https://github.com/FACK1/OSky/blob/master/oSky.html#L26

If the code doesn't work, it should not be in master!

In this line you are using the tag to nest text instead of using semantic HTML and using the appropriate tag for it. e.g [p] if it's a paragraph, [h2] if it's a sub-heading, [h3] if it's a sub-sub-heading and so on and so forth. Semantic HTML is important for accessibility and SEO since screenreaders and search engines rely heavily on how an html document is structured.

Edited To Add: is usually used to target a certain piece of text in another tag. e.g:

[p]Hello World, How are you today?[/p]

If you only wanna target the word "are" to style it for example, you'd do enclose the word "are" in span tags, give it an id and target it.

On line 16, inside the you are using inline css instead of external css, which is considered bad practice. Simply because it's hard to maintain and edit. Consider this: if the client wants any future changes it would be too much of a hassle to find and edit inline css for each element especially in a huge project.

In these lines, when the screen width getting narrow the text still with the same size for the wide screen.

Like I said in #18, good first attempt at a readme, however, you should learn how to format markdown, to make it a bit easier to read.

Here is a good guide on writing a good readme

And here is a good guide on learning markdown

team users