Giter VIP home page Giter VIP logo

Comments (8)

birick avatar birick commented on August 23, 2024

For my current playthrough, my 24-hour buff routine includes over 200 spell casts. I simply can't function without a feature to help manage so much buffing by a team including an Azata Archanist.

So this is a must-have feature for me. Instead of waiting, I went ahead and taught myself how to mod, and implemented this feature. I hope this is helpful to others, and I've submitted a pull request back to this repository so that others may use too.

This pull request adds a new option "Control Azata Zippy Magic Secondary Buff" as seen in screenshot:

image

When this checkbox is checked, an Azata secondary buff using Zippy Magic will no longer be cast on a random ally outside the functioning of the mod. Rather selecting any two characters to receive the buff will only count for 1 spell cast.

For example, in the screenshot, 10 characters are selected to receive the Mage Armor spell. Using the Azata option, this will count for only 5 casts of the spell from my main character. If 9 characters were selected, then 5 casts would be counted. If 8 characters were selected, then 4 casts would be counted. And so on...

If the Azata option is not checked, then 10 casts would be performed as usual. However, your Azata would actually cast the spell 20 times, with half of those being wasted. So the idea in providing this option is to prevent wasting this wonderful Azata superpower.

This pull request also includes updates to the calculation of available spells to accommodate when the Azata option is checked. For example, my main character may cast 14 level 1 spells. With Azata Zippy Magic, if the Azata cast all 14 as buffs, then that would allow for a total of 28 level 1 buffs to be cast. Checking the Azata option, for say Mage Armor + Magic Weapon Primary + Magic Weapon Secondary, will correctly allow for selecting 28 targets to receive those spells from the Azata. The portrait highlights, casting limits, and calculations displayed for each spell should be correct.

I've also tested that this works correctly for both instant buffing and buffing with animations.

I hope this helps! Let me know if any issues in the pull request :)

from bubblebuffs.

birick avatar birick commented on August 23, 2024

Initially implemented in commit dee33c0.

from bubblebuffs.

birick avatar birick commented on August 23, 2024

Per advisement improvement implemented in 131102c.

from bubblebuffs.

birick avatar birick commented on August 23, 2024

Correct bug where arcane reservoir points might not be available for Azata Zippy Magic secondary cast dddaf60.

from bubblebuffs.

birick avatar birick commented on August 23, 2024

Fix animated casting bug when casting last Azata secondary buff but spell slots are already expended 4b40fb3.

from bubblebuffs.

birick avatar birick commented on August 23, 2024

IsAOE is not the same as IsMass! Bug fix 9bbaf3a.

from bubblebuffs.

birick avatar birick commented on August 23, 2024

Here's a test with 250 buffs using the instant engine. Code is looking stable in testing.

image

from bubblebuffs.

birick avatar birick commented on August 23, 2024

Found and fixed the case when a spell has a material cost and is the secondary buff.

from bubblebuffs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.