falconair / nodefix Goto Github PK

I am installing a fresh MEAN* stack. I am getting the npm security audit on this package for underscore.string dependency.

The solution is to upgrade the underscore.string to the latest version of >=3.35. Currently, it seems the package.json is using version 1.1.4

Error info: https://npmjs.com/advisories/745

"dependencies": {
    "pipe": "0.0.2",
    "underscore": "1.1.6",
    "underscore.string": "1.1.4"
  },

Try to use a single mechanism to handle resend requests

I spent some time today going through the nodefix code and upcoming fix.js code. I have some critical doubts. Can you please help me get a better understanding?

Shouldn't we be creating sessions at connection level? In your implementation, it seems that you are maintaining the session at server level, so basically only one client can connect to it at one moment.

Is that the desired behavior or is my understanding flawed?

Should be taken out of session processor:

1. checking for compids and version
2. heartbeats
3. testreqid (1)
4. logout ack (& disconnect?)
5. login ack

In the function which converts it to text msg, by then it is too late to allow wrong information (client/server sims) handle seqnums correctly for resend/gap fill, etc.

In session processor? makes sense since this is session information?

Only fill in information if the user didn't provide it? if user did provide it, keep it?

remove useless comments
remove redundant this.func = func1 type statements
reduce the lines of code used to check for missing tags
replace tag numbers with tag mnemonics for comparisons

vars such as recorded comp ids, heartbeat int, etc. should be in context and available to all handlers

any place an 'ERROR' is logged, it should be sent via pipe for the client to process

'nodefix' seems to have changed names to 'fix' ?
http://search.npmjs.org/#/fix

On the readme -- this is old?
npm install nodefix

Instead of sending raw messages, send a data structure which contains the 'data' as well as the 'type.'

The types can be:
-admin events
-data
-?

Where does this error come from and how can it be resolved.

I'm trying to install dependencies with yarn and I'm getting this error

I don't se setting username +password?