Giter VIP home page Giter VIP logo

Comments (4)

michelescarlato avatar michelescarlato commented on August 29, 2024 2

Hi there,

I performed the modification suggested by @gdrosos Giorgos.

I merged this branch with the proposed modification.

from fasten.

michelescarlato avatar michelescarlato commented on August 29, 2024

Can I have a look at the branches that still trigger the Build and push the license feeder Docker image and Build and push the python license detector Docker image ?

I did a bit of cleanup (removing unmerged branches, as asked by Antoine @amottier), and now it could be handled.
But maybe by mistake wrongly declared GH actions have been "dragged" into other branches.

from fasten.

gdrosos avatar gdrosos commented on August 29, 2024

Hello, the root cause of the issue are those 3 lines at the deployment files:

pull_request:
branches:
- develop

More specifically, in both Build and push the license detector Docker image, Build and push the license feeder Docker image and Build and push the python license detector Docker image actions, the worflows are configured to be triggered every time a modification is placed on a pull request targeting the develop branch.

Therefore, I would propose removing this configuration and keep triggering the actions only on pushes on specific branches.

from fasten.

michelescarlato avatar michelescarlato commented on August 29, 2024

Hello, the root cause of the issue are those 3 lines at the deployment files:

pull_request:
branches:
- develop

More specifically, in both Build and push the license detector Docker image, Build and push the license feeder Docker image and Build and push the python license detector Docker image actions, the worflows are configured to be triggered every time a modification is placed on a pull request targeting the develop branch.

On push or pull_request on develop, the three GH actions that creates the 2 license detectors (the ones that include Scancode) and the Java license feeder, are triggered.

Therefore, I would propose removing this configuration and keep triggering the actions only on pushes on specific branches.

There are no side branches for licensing anymore. All is in develop.

Consider that all these plugins uses the fasten core library.

If any modification on the core is performed, it makes sense that these GH actions run (there may be modifications that breaks the license detectors, as well as the Java license feeder).

from fasten.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.