fastlane / frameit-frames Goto Github PK

Hi, Apple metadata rejected due 12.9-inch iPad Pro screenshots do not display the app in the correct device frame, iPad Pro (3rd Gen) doesn't have the home button.
Is there a way to force the device frame by Apple?
Thanks.

Hi!

This way it would match the name of the device you have to upload to the App Store.
Right now you will get an error message that the corresponding frame is missing.

I was only able to recognize the correct name be having a look at #18 .

fastlane frameit --force_device_type "Surface Pro X Black"
[✔] 🚀 
[20:07:13]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
[20:07:14]: Error setting value 'Surface Pro X Black' for option 'force_device_type'

[!] Invalid device type 'Surface Pro X Black'. 
Available values: iPad 10.2, iPad Air 2, iPad Air (2019), iPad Mini 4, iPad Mini (2019), iPad Pro, 
iPad Pro (12.9-inch) (3rd generation), iPad Pro (12.9-inch) (4th generation), 
iPad Pro (10.5-inch), iPad Pro (11-inch), 
Google Pixel 3, Google Pixel 3 XL, Google Pixel 4, 
Google Pixel 4 XL, Google Pixel 5, HTC One A9, HTC One M8, Huawei P8, Motorola Moto E,
 Motorola Moto G, Nexus 4, Nexus 5X, Nexus 6P, Nexus 9, Samsung Galaxy Grand Prime, 
Samsung Galaxy Note 5, Samsung Galaxy Note 10, Samsung Galaxy Note 10+, 
Samsung Galaxy S Duos, Samsung Galaxy S3, Samsung Galaxy S5, Samsung Galaxy S7, 
Samsung Galaxy S8, Samsung Galaxy S9, Samsung Galaxy S10, Samsung Galaxy S10+, 
Xiaomi Mi Mix Alpha, iPhone 5s, iPhone 5c, iPhone SE, iPhone 6s, iPhone 6s Plus, 
MacBook, iPhone 7, iPhone 7 Plus, iPhone 8, iPhone 8 Plus, iPhone X, iPhone XS, 
iPhone XR, iPhone XS Max, iPhone 11, iPhone 11 Pro, iPhone 11 Pro Max, 
iPhone 12, iPhone 12 Pro, iPhone 12 Pro Max, iPhone 12 Mini, iPhone 13, 
iPhone 13 Pro, iPhone 13 Pro Max, iPhone 13 Mini

There are 2 Surface Pro devices in the list at
https://github.com/fastlane/frameit-frames/tree/gh-pages/latest

It seems there is no matching code in
https://github.com/fastlane/fastlane/blob/master/frameit/lib/frameit/device_types.rb
?
Note that I am new to fastlane... maybe I am missing something?

Thanks

Could you please update the device frames. Facebook (https://design.facebook.com/toolsandresources/devices/) has some new devices like the S22 and so, is it possible to add these new devices? It would be also nice if we have more mordern android tablet devices (like the samsung galaxy tab series), the Nexus 9 looks very old.

Hey folks! Thanks for an awesome product.

I realize these new devices are just making their way out into the field, so I'm sure someone's already on it, but I didn't see a formal Issue request logged for this yet, so here it is:

• iPhone 13 (Pink, Blue, Midnight, Starlight, Red)
• iPhone 13 Pro (Sierra Blue, Silver, Gold, Graphite)
• iPhone 13 Pro Max (Sierra Blue, Silver, Gold, Graphite)
• iPad Mini (2021) (Space Gray, Pink, Purple, Starlight)
• iPad (2021) (Space Gray, Silver)

Version 1607001240 removed some older device frames like the old SE.

When running frameit, it still tries to match it and finds the new SE. The offsets do not fit though.

I think the device naming is not very useful, the files should match the device names used by Xcode.

Hi
Can you please update latest iPhone skins

There is no frame for iPad Pro (12.9-inch) (2nd generation). I checked on Facebook frameset and it is missing there as well.

Anyone knows where to find the frame for iPad Pro (12.9-inch) (2nd generation)? My current workaround is to manually screenshot the frame from an active iPad Pro (12.9-inch) (2nd generation) simulator, which is apparently not ideal.

I experience the same error as described here
#10 (comment)

I believe there is a typo in letter X.

I think the URL for main repo is https://github.com/fastlane/fastlane/tree/master/frameit. Let me know if I am correct I will create a PR for that.

the first time I run

fastlane frame

I got error.

INFO [2017-04-17 20:43:46.72]: Downloading file from 'https://fastlane.github.io/frameit-frames/1478730760/files.json' ...
INFO [2017-04-17 20:43:51.86]: Downloading 1 of 41 files from 'https://fastlane.github.io/frameit-frames/1478730760/Apple%20iPhone%205c%20Blue.png' ...
ERROR [2017-04-17 20:44:04.82]: Operation timed out - connect(2) for 151.101.88.133:443 (Errno::ETIMEDOUT)
/usr/local/lib/ruby/gems/2.4.0/gems/fastlane-2.27.0/fastlane_core/lib/fastlane_core/ui/interface.rb:150:in `user_error!': [!] Error accessing URL 'https://fastlane.github.io/frameit-frames/1478730760/Apple%20iPhone%205c%20Blue.png' (FastlaneCore::Interface::FastlaneError)

It aborted to continue .But I typed https://fastlane.github.io/frameit-frames/1478730760/Apple%20iPhone%205c%20Blue.png into Chrome, it can be downloaded.

So I downloaded zip of repository, and put it into '/Users/hite/.fastlane/frameit/' , run fastlane frameit.
The problem was solved.

So any suggests?

Since the last version (1607001240), the iPad Pro frames are not present anymore, even though App Store Connect still requires screenshots for the iPad Pro 12.9-inch (2nd generation) to be uploaded.

Error logs:

Unfortunately device type 'Apple iPad Pro' is not available in Silver, falling back to Space Gray...
Couldn't find template for screenshot type 'Apple iPad Pro Space Gray'
Please run `fastlane frameit download_frames` to download the latest frames

Since the new update, I cant download the latest frames