fathoor / simkes-api Goto Github PK

Bug Description

Route for get and put pegawai akun is not providing proper route, route is taking query parameter instead of path parameter

Current route is set to:

/v1/akun/pegawai/detail/{nip}?nip={nip}

Expected Behaviour

Route should take path parameter instead of query parameter, expected route should be set to:

/v1/akun/pegawai/detail/{nip}

Feature Description

Maximum file size to upload should be limited to around 2-5 MB (2*1024*1024 - 5*1024*1024)

Code Snippet (Optional)

if request.File.Size > 2*1024*1024 {
    return "", exception.BadRequestError {
        Message: "File size exceeds limit",
    }
}

Bug Description

Provided path to swagger.json is set to:

././docs/swagger.json

Expected Behaviour

It should've provided swagger.json path with:

../../docs/swagger.json

Bug Description

Updating an existing data returns error (Data already exists) due to the validating logic to check if the requested data already exists

Expected Behaviour

Should return success alongside with the updated data in the response data