fatih / motion Goto Github PK

I suppose this is more of an issue for vim-go but my understanding is that it uses motion entirely to implement the :GoDecls and :GoDeclsDir feature so any changes would need to be made here first.

Is it possible/desirable/allowable to make the directory version of -mode decls recursive to all subdirectories? I have a gomod style project that has a number of subdirectories implementing child packages for the main codebase and it would be much more helpful if :GoDeclsDir returned every declaration across my entire codebase instead of just the ones for whatever child directory the current file I'm editing is inside.

Presumably this would be supported by an additional flag/configuration setting so as to not break backwards compatibility, I suggest either just a plain -recursive style flag or allowing the -dir flag to take multiple arguments so you could call it as -dir maindir/* or something similar.

This panics:

package main

func foo(bar string)

func main() {}

This is valid AST, but not valid go program. Can easily happen during refactor or if we write new code.

I got following output with motion -mode decls -include func -file session.go:

{
  "keyword": "func",
  "ident": "removeFiles",
  "full": "func (s Session) removeFiles() err error",
  "filename": "/Users/vbauer/go/src/github.com/vbauerster/getparty/session.go",
  "line": 184,
  "col": 1
}

Then I pass full field to gofmt for my needs. However gofmt complains of course, because of missing parentheses:

"full": "func (s Session) removeFiles() err error",

it should be:

"full": "func (s Session) removeFiles() (err error)",

It happens only with single named return type, like (err error) in this case.

this shares a binary name, motion, with https://github.com/Motion-Project/motion. I am looking to package this up on arch, and realised there was a conflict. any thoughts?