fdel15 / fdel15.github.io Goto Github PK

Hi Frank,

I'm leaving some feedback for challenge 8. I really like the layout of your website, we must have had a pretty similar wireframe. I also really like the skyline background and I think the icons look really good the way they are sized and positioned at the bottom. My only suggestion is to change the color of the text in the middle of the page--the white gets a bit lost in the building lights. Look forward to seeing the next round!

Hey Frank!
Diggin the site man. Excellent work so far for sure. I like the background image and the set up you're working with. The social media buttons look great. The one bit of constructional feedback I have is that the site doesn't say your name anywhere!
Best wishes,
Ricky

I like the effects on your navigation bar and the clean-looking social media links you've placed at the bottom.

This is mostly a personal aesthetic preference, but I would recommend against using Comic Sans. I know even Codecademy is guilty of using it.

Other suggestions: Put all of your text into tables with opaque backgrounds to make the text easier to read. Although the skyline image is nice, it doesn't fit resolutions higher than 1080p and ends up creating a tile effect.

Nice work!

Hey Frank,

First off, I would like to say thanks for my feedback! I am aware of those problems but I just haven't gotten around to them yet! I really like your post and I can definitely tell you know what you're talking about! Your design on your page is nice and simple, which is good! It's easy to look at and your wording is straight forward and to the point. It's hard to find anything constructive to say, but If I had to say something is just in the future, maybe a navigation bar or something. Something that'll take me somewhere quick and easy without having to go to the back button. Keep up the good work man!

Hi Frank,

Great explication of group_by. That's not a method I've used before, but it's obviously very versatile. I wouldn't have even thought to use the string sorting code block. In short, there's a lot of useful info in there.

A quick CSS suggestion. Add some padding to the right of your body text, as it runs right against the border there. Also, the img of the code from Ruby Docs may look better with:
margin: 0 auto 0 auto;
display: block;

That will center it in your content div.

Best,
Luke