Tox 4.0.0 was released. We need to decide what to do about that. Since this docker image uses stable Fedora, it will contain tox3 for a while. Should we document that and let it be? Should we package a conflicting version of tox4 into Fedora? etc.

See #60 (comment)

Seems like you are moving to Fedora N+1 when N goes EOL? If so, just a small suggestion: it deserves a note in the README file that this is the policy. Then nobody will be "shocked" the container is too old. :)

We have discussed this briefly with @encukou today. When we switch to F35, we might break someone's CI because F35 does not contain Python 3.5.

My idea is to build container images and create manifests with the fedora version in their name and release a new version of Github action every time we switch to a newer Fedora release.

We can build all the container images with the original tags like amd64 and amd64_fedora34. The same applies to the latest manifest where we can use latest and latest_fedora34. We can then change the github action to use latest_fedora34 explicitly. Then, when we switch to Fedora 35, the tags and manifests using _fedora34 suffix will stay the same, and therefore the github action will stay stable and we can release a new version of the github action using _fedora35. Also, those who use the images directly can choose between a stable and possibly obsolete version of the images or rolling tags.

Does this make sense?

See: encukou/py3c#39 (comment)

During build with Python 3.7 I found out that there is something wrong with the newest Pypy3 from COPR.

$ docker run --rm -it -v $PWD:/src -w /src frenzymadness/fedora-python-tox
# Pypy is ok
pypy installed: cffi==1.10.1,greenlet==0.4.12,py==1.5.2,pytest==3.2.5,readline==6.2.4.1
pypy runtests: PYTHONHASHSEED='618530766'
pypy runtests: commands[0] | pytest
========================================== test session starts ==========================================
platform linux2 -- Python 2.7.13[pypy-5.8.0-final], pytest-3.2.5, py-1.5.2, pluggy-0.4.0
rootdir: /src, inifile:
collected 10 items                                                                                       

test_fac.py ..........

======================================= 10 passed in 0.05 seconds =======================================
# But Pypy3 not
Traceback (most recent call last):
  File "/usr/bin/tox", line 11, in <module>
    load_entry_point('tox==2.7.0', 'console_scripts', 'tox')()
  File "/usr/lib/python3.6/site-packages/tox/session.py", line 39, in main
    retcode = Session(config).runcommand()
  File "/usr/lib/python3.6/site-packages/tox/session.py", line 392, in runcommand
    return self.subcommand_test()
  File "/usr/lib/python3.6/site-packages/tox/session.py", line 543, in subcommand_test
    if self.setupenv(venv):
  File "/usr/lib/python3.6/site-packages/tox/session.py", line 461, in setupenv
    envlog.set_python_info(commandpath)
  File "/usr/lib/python3.6/site-packages/tox/result.py", line 49, in set_python_info
    "import sys; "
  File "/usr/lib/python3.6/site-packages/py/_path/local.py", line 714, in sysexec
    stdout, stderr,)
py.process.cmdexec.Error: ExecutionFailed: 1  /src/.tox/pypy3/bin/python
debug: WARNING: Library path not found, using compiled-in sys.path, with
debug: WARNING: sys.prefix = '/builddir/build/BUILD/pypy2-v5.8.0-src'
debug: WARNING: Make sure the pypy binary is kept inside its tree of files.
debug: WARNING: It is ok to create a symlink to it from somewhere else.
debug: OperationError:
debug:  operror-type: ImportError
debug:  operror-value: No module named os

Because I don't have time to inspect it now, I decided to remove COPR repo from Dockerfile and use standard Pypy3 from Fedora repositories.. frenzymadness@ff004e7

@hroncok IMHO you know Pypy better than me.

The latest build by Travis cron failed on ppc64le:

$ docker run --rm -e TOXENV -e GIT_URL=https://github.com/[secure]/python-tox-example.git fedorapython/fedora-python-tox:$TRAVIS_CPU_ARCH
Cloning into 'temp_project_dir'...
fatal: unable to access 'https://github.com/[secure]/python-tox-example.git/': OpenSSL SSL_connect: Connection reset by peer in connection to github.com:443 
ERROR: tox config file (either pyproject.toml, tox.ini, setup.cfg) not found
The command "docker run --rm -e TOXENV -e GIT_URL=https://github.com/[secure]/python-tox-example.git fedorapython/fedora-python-tox:$TRAVIS_CPU_ARCH" exited with 1.

I thought it might be some problem in OpenSSL on ppc64le but I'm not able to reproduce the issue. I've opened an issue on Travis CI support so we'll see what they'll come with.

Because there seem to be some incompatibilities between attrs module (pytest dependency) and Jython, it might make sense to rewrite tests to use the unittest module instead of pytest.

pytest-dev/pytest#3111
python-attrs/attrs#321

The only reason it's not in Fedora is temporary lack of 32bit support.

See https://copr.fedorainfracloud.org/coprs/g/python/pypy35/

Find a way how to build docker image only once before running tests.

I have multiple python packages in subdirectories in my repository, each having a tox.ini file. It would be useful to me if I could have run_scripts.sh cd to a subdirectory before running tox.

Related to fedora-python/tox-github-action#16

This is a placeholder issue to add PyPy 3.10 to the container once available in Fedora 37.

Progress:

• PR merged https://src.fedoraproject.org/rpms/pypy3.10/pull-request/8
• pypy3.10 built in f37 https://koji.fedoraproject.org/koji/taskinfo?taskID=105120661
• bodhi update created https://bodhi.fedoraproject.org/updates/FEDORA-2023-1b78796ec4
• bodhi update reaches stable
• pypy3.10 available on the f37 mirrors
• pypy3.10 added to https://github.com/fedora-python/fedora-python-tox/blob/master/Dockerfile

When there are no changes in here, the Docker image can get a bit outdated. Would you consider building it weekly by cron?

Tests with Jython fail because Jython doesn't work with the latest pip and therefore cannot install pytest dependency.

Upstream bug: pypa/pip#5121

It would be nice to pass somehow git URL into the docker so that it would automatically clone the requested repository and run tox command on top of it using the supplied tox.ini from fedora-python-tox.

It could be done using env. variables, extending docker entry point with additional/custom arguments taken from docker run, some special config file (with multiple git URLs) etc.

Detox (fedora package python-detox, or python3-detox when built) allow to run tox environments in parallel. Would you accept a PR that adds it?

SSIA

Add python37. (I don't have time to do it right now, so opening an issue, but I'll gladly do it next week.)

The latest successful Travis build happened 3 months ago (with Python 3.10.0b1) and since June 15th, 2021, the building on travis-ci.org is ceased.

As a result, the Pythons are outdated:

My machine:

$ rpm -qa | grep -F python3. | sort
python3.10-3.10.0~rc1-1.fc33.x86_64
python3.5-3.5.10-5.fc33.x86_64
python3.6-3.6.14-1.fc33.x86_64
python3.7-3.7.11-1.fc33.x86_64
python3.8-3.8.11-1.fc33.x86_64
$ rpm -q python3
python3-3.9.6-2.fc33.x86_64

This image:

[root@9808fb7fd92c /]# rpm -qa | grep -F python3. | sort
python3.10-3.10.0~b1-1.fc33.x86_64
python3.5-3.5.10-5.fc33.x86_64
python3.6-3.6.13-1.fc33.x86_64
python3.7-3.7.10-1.fc33.x86_64
python3.8-3.8.10-1.fc33.x86_64
[root@9808fb7fd92c /]# rpm -q python3
python3-3.9.5-1.fc33.x86_64

The only up to date Python is Python 3.5, because it is EOL

Jython is basically not supported by tox/pip/pytest etc. and with every new release of those components, a new way it fails appears.

Do we want to keep it in the image and document that it has a limited support and tox (which is the main tool we use here) does not support it, or just remove it?

Should we add Jython?

$ssia

Notably, detox is gone (replaced by tox --parallel).