fedwiki / wiki-plugin-assets Goto Github PK

Last weeks weekly wiki meeting discussed was Firebase hosting. Paul would need to write a "site-adapter for Firebase".

I'm very interested in deploying to Firebase, because with typical traffic hosting is free. I searched for dev doc on witting a site-adapter, is assets.coffee code that I can use as a template. All direction and pointers appreciated.

If a site in the page's history is not reachable the plugin output contains page html

The same thing is happening if the route to the remote site is not yet determined.

Paul90: I get the server crashing when I try and upload an image. In the asset plugin the fs.rename on line 43 is missing a callback. The callback is no longer optional.

https://github.com/WardCunningham/wiki-plugin-assets/blob/9a642fb06922b803478a21dee5f6c1a7e5b110f6/server/server.coffee#L43

See node documentation

The callback should check for error and abort the upload similar to the error handling on subsequent lines. The error status and message will be relayed to the user by the client without much ceremony.
https://github.com/WardCunningham/wiki-plugin-assets/blob/9a642fb06922b803478a21dee5f6c1a7e5b110f6/client/assets.coffee#L124