Giter VIP home page Giter VIP logo

Comments (4)

felixpalmer avatar felixpalmer commented on May 17, 2024

I don't have an Android device to handle to test on sorry, so I cannot reproduce this. However, I spent a lot of time working on fixing picking on Android recently and did have it working. Could you double check that the production build you are testing with is indeed using the latest 1.0.17 version of the code? I ask because the glitch.com demo you sent doesn't display the icons correctly, so I figured it isn't actually what you are testing with.

Also, could you check whether clicking works for you on this demo? https://olwal.github.io/air/3d/ - this is what I was helping to fix and I've been told it now works correctly on Android

from procedural-gl-js.

Shalwaban avatar Shalwaban commented on May 17, 2024

The air/3d demo works for me on Android using Firefox, but not Chrome.
So then I tested my glitch example on Android/Firefox and it works! And it still doesn't work on Android/Chrome.
(In the glitch demo I switched the icons to white, they might have been hard to see when no map was loaded)

from procedural-gl-js.

felixpalmer avatar felixpalmer commented on May 17, 2024

One thing to bear in mind is that the markers are actually bigger than you think because you have added a padding (set a background to a solid colour to see this, say "background": "blue"). This means that when they are close by they will overlap when hittesting even if the white circles do not.

Screen Shot 2021-03-16 at 11 33 52 AM

I've had a look at the code and made a slight tweak that might fix this for you - can you try with the latest version (1.0.18)?

As for debugging this further - who knows what is up with Android/Chrome here. To help narrow down the exact issue could you try and see if it is broken or works on Android/Chrome in the following cases:

  • Overlay with one point with id of 0
  • Overlay with one point with id of 1
  • Overlay with one point with id of "test"
  • Overlay with two points with ids of 0 & 0 respectively
  • Overlay with two points with ids of 0 & 1 respectively
  • Overlay with two points with ids of "test" & "test2" respectively

from procedural-gl-js.

Shalwaban avatar Shalwaban commented on May 17, 2024

Thanks for the info about the padding.

With 1.0.18 / Android 6 / Chrome 89:

  • Overlay with one point with id of 0
  • Overlay with one point with id of 1
  • Overlay with one point with id of "test"
  • Overlay with two points with ids of 0 & 0 respectively
  • Overlay with two points with ids of 0 & 1 respectively
  • Overlay with two points with ids of "test" & "test2" respectively

On Firefox, all benchmarks passed.

https://glitch.com/edit/#!/0316s

from procedural-gl-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.