Comments (8)
Having a peek, I think (though could be wrong), that this is because there is no check for -r
while checking for the mismatch of lengths. I guess that will have to check if they're off by one if -r
is invoked. I'll try fiddle with it my end and submit a PR if it works, unless you get to it first.
from phyx.
Can confirm. Sorry about that. I will have a look later today. It should take a few minutes, but I am heading out the door.
from phyx.
Ok I see what is going on. Be back soon.
from phyx.
Should be fixed with 9f15c7a
from phyx.
Sorry I missed your PR. I think mine works well (will put in a few tests). Yours looks fine if you can assume all files are what they say they are (nuc and associated pep). If you've somehow mixed up files, your fix will allow the program to proceed (i.e., counts are explicitly set to be equal), but would crash if the lengths are not what they should be (say, a nuc alignment shorter than the peptide on). Just thinking of ways people can break things (>ᴗ•)
from phyx.
That works! Although I note that it makes the codon count in the error message for mismatching lengths off by one, e.g.
pxaa2cdn -r -a test.pep.fa.txt -n test2.cds.fa.txt
Error: for taxon '1' nucleotide alignment involves 4 codons, but protein alignment involves 2 amino acids. Skipping.
Error: for taxon '2' nucleotide alignment involves 4 codons, but protein alignment involves 2 amino acids. Skipping.
But test2.cds.fa.txt
has 5 codons, etc...
Anyway, I see what you mean about my PR, will close it! Many thanks for dealing with it so quickly.
from phyx.
Erg yes I'll fix the warning.
from phyx.
legend, thanks!
from phyx.
Related Issues (20)
- phylip gets corrupted when piped HOT 3
- a strange thing about pxrms program HOT 10
- pxtlate detects AA when DNA is present HOT 2
- duplicated species in clade groupings with pxbp
- How to install phyx on linux without root access ? HOT 5
- pxrlt and pxrls only change the final name on the list HOT 9
- pxrlt and pxrmt doesn't output tip name with "-" correctly HOT 5
- strange behavior with pxbp on computing cluster HOT 7
- pxcomp outputs an enormous file, or rejects unaligned sequences. HOT 6
- phyx installed HOT 11
- pxaa2cdn -r (again) HOT 10
- infinite loop in superdouble implementation with gcc 13 HOT 3
- Unable to ./configure HOT 4
- Debian 12 install, pxseqgen HOT 3
- autoconf error in installation HOT 5
- pxssplit: command not found HOT 6
- pxrms .txt file using wildcard HOT 6
- Phyx errot: double free or corruption (!prev) HOT 4
- GHA failing for mac (armadillo) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phyx.