ferreusveritas / cathedral Goto Github PK

Hi
So I'm putting together a bunch of mods for a friend and I to play and discovered probably the weirdest incompatibility I've come across. If I have ZarakLib (a dependency for multibags https://minecraft.curseforge.com/projects/zaraklib) and Cathedral installed and then try to apply the Monsterley (https://minecraft.curseforge.com/projects/monsterley) resource pack it will fail to apply the resource pack.

If I uninstall either ZarakLib or Cathedral I can apply Monsterley just fine. I can also apply other resource packs with both installed. I spent so long tracking this thing down and I'm quite baffled.

Here is the pastebin of the log error:
https://pastebin.com/AnEGf0xh

Any idea why this is happening? I'm not sure which of the three things is actually causing the problem, but I would love to know so that I can notify Monsterly or Multibags about it. I've commented one their pages with the error as well, but Cathedral is the only one with a github. Perhaps you can shed some light on this weird bug I've discovered.

https://imgur.com/a/5vpF7b4

I added Cathedral to my pack to test it (and look at its blocks, since there's no preview images yet) but found that I could not craft the Dwemer blocks. No crafting recipe shows up in JEI (the chiselling recipes work fine).

I checked the code, and found the recipe as registered in Dwemer.java: eight basalt surrounding a metal ingot. AFAICT my pack does not include any items dictionaried as ingotDwemer, ingotDawnstone, ingotBronze, or ingotBrass, so the fallback is presumably the basic ingotGold. I double-checked that the gold-ingot recipe doesn't work by putting it into the crafting table anyway (in case it was just JEI missing it) but it also failed.

My pack does not contain any mods from the Thermal series, but it does contain some other mods that might themselves include compatibility code for some of the referenced metals; IIRC molten bronze for Tinker's Construct exists despite neither bronze nor tin being added by any extant mod—it may be a multi-mod compatibility issue.

I'll try to help narrow down the issue by copying my pack to a new instance and whittling down the modlist to the mods necessary to duplicate it.

Forge version 14.23.5.2838
Building Gadgets version 2.6.8
Cathedral version 1.12.2-1.9.7k
https://gist.github.com/LemADEC/62ac8e96d130ae69dd4924b5b7c3079f

** How to reproduce the issue
Get an Building Gadgets mod's Exchanger and set it to the Cathedral mod's Dwarven pillar
Trying to use it or change it causes a crash

As reported initially here: Direwolf20-MC/BuildingGadgets#323

When using the Fancy block particles mod, and breaking a railing block, sometimes one of the particles is one of the pink and black thingies.

While I'm not sure you want to expand more on the contents of the mod, I have a few suggestions:

-Perhaps add stair and slab variants for each basalt block type (some are already included), also Dwemer Metal Panel stairs/slabs.

-Some more decorations to go with the Dwemer stuff would be great! In particular, modelled gaslamps with little blue flame particles that can be hung from chains, roofs, or on walls would be brilliant. Maybe also some Dwemer variants of vanilla mechanical blocks like Furnaces, Pistons, Hoppers, Droppers, Dispensers, Levers, etc. Perhaps a few simple automaton or head statues since personally I don't find the metal Gargoyles quite fit the style these blocks are going for.

-More types of stained glass would always be appreciated, though I can understand these may be difficult to design well.

-Trapdoors! Maybe even 1x2 or 2x2 trapdoors. Also variants for them and the doors which can only be opened with redstone would be a nice touch.

-Also perhaps go over the metal textures for some of the Dwemer stuff again. The blocks are beautiful already, but things like the carvings and doors and railings and panels and a few of the blocks like chains, etc. seem to have significantly less of a "metal" appearance than the fences and metal window blocks and the scale pillar, etc. It's either a color or shading difference, maybe both, it's hard to tell. The difference is admittedly kind of distracting to a stickler for details such as myself.

I know I went kind of overboard with the Dwemer suggestions. Honestly I feel like you could flesh it out into its own entirely Dwemer-Themed decoration and mechanical mod. Maybe even with creating automatons or such. I can imagine that with Embers compatability or something and that would just be positively amazing.
That said, one last suggestion- calling this stuff Dwemer may be a bad idea. Bethesda really doesn't like people using their names. Renaming to "Dwarven" would probably be a safer idea. (Not that I don't appreciate another fan of the long-lost Deep Folk of The Elder Scrolls and their architecture, devices, and style.)

gargoyles don't render correctly with smooth lighting on when using optifine.

Cathedral 1.12.2-1.9.7g

When a checkered slab is mined it drops a raw basalt slab instead of a checkered slab.

When I load up this mod along with hardcore item stages and the required dependencies, the game crashes on startup. Could this be fixed?
Crash Report: crash-2022-01-27_23.42.08-client.txt

As of 1.12.2-1.9.7k, Dwarven Pillar and Tall Dwarven Door are sharing the same recipe:

[Client thread/WARN] [Chisel]: Mod cathedral is using deprecated IMC variation:add! This IMC type may be removed soon, please notify the author of this mod.

Using DeckPrisn on block with ConTex, like the Dwemer Pillar, make the block use the full CT Texture

Using DeckPrism on 3D Pillar make them invisible with a CCL error message(InLogs relevant stuff)

https://paste.dimdev.org/ecegalemug.mccrash

Merely reporting this for them.

I notice a few missing blocks in the pictures on the mod page that are not actually included. In the "crafting hall", "deep village",and "Morian pillars" images there are small flat lights and hanging Dwemer-style lamps, neither of which appear to be in the mod currently. Additionally in the "storage silos" picture, there's what appears to be horizontal metal panes, when neither horizontal nor vertical metal panes are even in the mod (there are fences which match the Ornate Metal but not the normal Dwemer Metal).

I'm not sure if these are the result of another mod, or simply not included in the current release, but it would be appreciated if that were cleared up.

As bronze chain is uncraftable without a mod adding bronze, the dwemer chain doesn't seem to have an alternate recipe

As of 1.12.2-1.9.7k, the top side of panels have holes / missing faces depending on what block is placed above:

Had a crash issue with this mod (or possibly one related to it?). Client loads up just fine but when loading a server I get the following crash. https://pastebin.com/821P60p6

Hope it's a simple fix, I really love this mod.

The short doors return an oak door, and the tall door just doesn't drop anything.

https://youtu.be/__r6R_lYzx4