fetchify-dev / magento2 Goto Github PK

Environment

• Magento CE 2.3.1
• Luma theme
• Craftyclicks_Clicktoaddress 1.1.8

Replication steps

1. Set default shipping country to "United Kingdom"
2. Add a product to cart
3. Go to guest checkout
4. In "Address Search" field click "Change Country"
5. Select Spain
6. Search for an address so that the results show a list of addresses, as oppposed to the region/city tree structure.
7. Click an address

Expected result

• Magento's address fields are populated. The country <select> changes from default country (UK) to CraftyClicks country (Spain)

Actual result

• Most address fields are populated by CraftyClicks
• Country <select> remains unchanged. The Spanish postcode fails UK postcode validation.
• (If you navigate through region/city results, then click an address, the Magento country field does update). This bug relates to address top-level results.

In the etc/admin/system.xml file should be type="obscure" for field "accesstoken" now it is type="text",

<field id="accesstoken" type="text" sortOrder="2" showInDefault="1"> <label>Access Token</label> <backend_model>Magento\Config\Model\Config\Backend\Encrypted</backend_model> </field>

https://github.com/craftyclicks/magento2/blob/master/etc/adminhtml/system.xml#L17:L20

When adding a new customer address in the admin, I get a JS error (Uncaught TypeError: Cannot read properties of undefined (reading 'getAttribute') at clickToAddress.attach).

Using version 2.4.1 on magento 2.4.3-p3

To replicate
In the admin go to
Customers > All Customers > Select existing
Click Addresses tab > Add new address
Inspect console

Environment

• Ubuntu 14.04 LTS (GNU/Linux 3.13.0-117-generic x86_64)
• nginx/1.4.6 (Ubuntu)
• MySQL 5.6.34-log
• PHP PHP 7.0.18
• Magento CE 2.1.9
• Craftyclicks_Clicktoaddress 1.0.5

Replication steps

1. Style checkout forms using Magento's built-in classes
2. Load guest checkout

Expected result

• Craftyclicks_Clicktoaddress form fields should be styled same as Magento's

Actual result

• Craftyclicks_Clicktoaddress' fields do not match styling of other form elements:
  

Cause

• view/frontend/web/form_integrations/cc_customer_address.js and view/frontend/web/form_integrations/cc_customer_address.js output <div class="value"> instead of <div class="control">

Solution

Here's my temporary composer patch:

--- view/frontend/web/form_integrations/cc_customer_address.js	Tue Nov 28 10:45:02 2017
+++ view/frontend/web/form_integrations/cc_customer_address.js	Tue Nov 28 13:41:25 2017
@@ -12,7 +12,7 @@
 			}
 			var tmp_html = '<div class="field"'+custom_id+'><label class="label">' +
 							c2a_config.texts.search_label+'</label>' +
-							'<div class="value"><input id="cc_'+cc_index+'_search_input" type="text"/></div></div>';
+							'<div class="control"><input id="cc_'+cc_index+'_search_input" type="text"/></div></div>';
 
 			form.find('#street_1').closest('.field').before( tmp_html );
 
--- view/frontend/web/form_integrations/cc_default_checkout.js	Tue Nov 28 10:45:02 2017
+++ view/frontend/web/form_integrations/cc_default_checkout.js	Tue Nov 28 13:41:25 2017
@@ -12,7 +12,7 @@
 
 			var tmp_html = '<div class="field"'+custom_id+'><label class="label">' +
 							c2a_config.texts.search_label+'</label>' +
-							'<div class="value"><input id="cc_'+cc_index+'_search_input" type="text"/></div></div>';
+							'<div class="control"><input id="cc_'+cc_index+'_search_input" type="text"/></div></div>';
 			form.find('[name="street[0]"]').closest('fieldset').before( tmp_html );
 
 			var dom = {

Environment:

Magento 2.1.4 EE
Craftyclicks_Clicktoaddress (ver: 1.1.1)

Steps to reproduce:

1. Set "Transliterate for non ASCII characters" to "Yes" under Store -> Configuration -> CRAFTY CLICKS -> Click to Address -> Advanced in the admin panel.
2. In the frontend go to checkout and try to search for an address (600028: India postal code in our case).
3. Click through multiple levels of suggestions

Expected Result:

When selecting the last suggestion, the address should be auto-filled in the checkout address form.

Actual Result:

The following Notice is thrown when trying to select the address suggestion:

"CraftyClicks Debug Error Message: [JS503] API address retrieve request resulted in a JS error."

Points to be noted:

1. When "Transliterate for non ASCII characters" is set to "No", all work fine.
2. First two levels of suggestion are selectable, only the last level throws the above error.
3. JS minification and merge are enabled in Magento.

There is an issue with the configuration. The checkout is broken after module installation if access token is not specified. The js config (c2a_config) is not generated correctly with empty token even if module is disabled.
Platform: Magento 2.0.5 EE

Steps to reproduce:

1. Install the module
2. Add product to cart
3. Proceed to checkout

Expected result:

Checkout shipping details form appears.

Actual result:

White screen. c2a_config is not defined error fired.

Hi,

on the magento 2.3.5-p1 and mageplaza one step checkout (latest) and your latest module, I am getting:

Uncaught Already initiated

Any hints ?

Hello!
Please, rewrite the code from

<field id="accesstoken" type="text" sortOrder="1" showInDefault="1" showInWebsite="1" showInStore="1">
					<label>Access Token</label>
					<backend_model>Magento\Config\Model\Config\Backend\Encrypted</backend_model>
					<validate>token-format</validate>
				</field>

to

<field id="accesstoken" type="obscure" sortOrder="1" showInDefault="1" showInWebsite="1" showInStore="1">
					<label>Access Token</label>
					<backend_model>Magento\Config\Model\Config\Backend\Encrypted</backend_model>
					<validate>token-format</validate>
				</field>

Namely, type text to type obscure.
Otherwise, the module does not work for Magento 2.4.3.

Value of default country in $cfg['autocomplete']['default_country'] populated in vendor/fetchify/module-fetchify/Helper/Data.php is not used in further ui component like $cfg['autocomplete']['enabled_countries'] . Which leads to setting default 'gbr' value in vendor/fetchify/module-fetchify/view/base/web/cc_c2a.min.js file and placing first country in allow countries list as a default country.
If checkout is default then in this file vendor/fetchify/module-fetchify/view/frontend/web/form_integrations/cc_default_checkout.js is missing code like this

if (typeof c2a_config.autocomplete.default_country !== 'undefined') {
   config.defaultCountry = c2a_config.autocomplete.default_country;
}

Adding this code fixes issue.

Steps to reproduce:

• Set default store Ireland
• Add to allowed list of countries any country higher then Ireland (e.g. Armenia, Belgium, Germany etc. )
• Armenia will be set as default country

At the moment I don't think it's possible to use a mixin to amend the postcode field rendered by cc_default_checkout.js.

Could somebody advise the best approach here?

It is impossible to save empty token in the module settings.
Platform: Magento 2.0.5 EE

Steps to reproduce:

1. Go to Stores->Configuration->Crafty Clicks->Click to Address
2. Enter non-empty Access Token and save the config
3. Clear Access Token input and save the config.

Expected result:

New empty token value is saved

Actual result:

Access token value is not changed. Old value is used.

Hi,

on magento 2.3.6 with default checkout and anowave's google tag manager module, there is an issue when trying to place the order: Uncaught (in promise) TypeError: Cannot read property 'checkout' of undefined

which is coming from Anowave's place-order.js file:

data.ecommerce.checkout.actionField.step = AEC.Const.CHECKOUT_STEP_ORDER;

This started to happen when we installed latest fetchify module, when its disabled, issue is gone . Wondering if there is a conflict somewhere between these two ?

Thanks

Hi,
one of our client's is using mageplaza one step checkout and now we upgraded both checkout module and craftyclicks to fetchify, and now when you are logged in and want to add new address on checkout, address lookup not working:

http://prntscr.com/1258t1w

As you can see, place holder is rendered but nothing happens when you start typing the address. But if you are guest or new customer, lookup is working on fine on checkout page itself.

No js issues in console.

Magento is 2.4.2 and latest fetchify module.

Thanks

If a customer decides to not use the postcode lookup service, the browser no longer sees street address line 1 as line 1.

It will attempt to autofill street address line 1 with street address line 2 data.

I've seen that PCA predict changes the autocomplete values for these inputs to prevent this from happening.
It would be good to see something similar.

The issue is, adding the additional input above street address line 1 means chrome detects this as the first street option