fidoafif / clloh-todo-ts Goto Github PK

Per the documentation in https://redux.js.org/api/bindactioncreators, there's no need to use bindActionCreators if we have dispatch available.

In https://github.com/fidoafif/clloh-todo-ts/blob/master/App/Containers/TodoList/EditTodo.tsx#L92 we have access to dispatch, so we don't really need bindActionCreators.

Because assignment is by reference in JavaScript, we are mutating state directly in https://github.com/fidoafif/clloh-todo-ts/blob/master/App/Containers/TodoList/EditTodo.tsx#L63-L66. We can confirm that this is a mutation if we do the following:

1. comment out https://github.com/fidoafif/clloh-todo-ts/blob/master/App/Containers/TodoList/EditTodo.tsx#L67 so that the store isn't updated
2. run the app
3. tap a todo and note down its original title / description
4. change the title / description and press the update todo button. Note we are not dispatching an action here so we expect that the store state isn't updated, i.e. the title / description should be unchanged
5. tap the todo and compare its current title / description with that in (3)

Expect

title / description to be the same in steps 3 and steps 5

Actual

title / description are different because we mutate the values directly.

If we mutate the app state directly, there will be more chances for bugs to happen.