filipsedivy / cnb-api Goto Github PK

• bug report? yes
• feature request? no
• version: 2.2

Description

I have code:
$code = 'EUR';
$cnb = new \CnbApi\CnbApi(storage_path('app/cnb'));
$a = $cnb->findRateByCode($code);
print_r($a);
exit;

When I run it, it shows error: Code 'EUR' not found
Where can be problem?

hi,

I've checked the package and thank you for it!

I wanted to contribute the codebase with an "Client" interface so I can make a test (without mocks). But I've noticed issues due the PHP versions constraints. I had to update:

PHPStan:
Seems ok, few errors that can be fixed

coding standard:
I had to enable plugin to use it. Fails on ERROR: Referenced sniff "SlevomatCodingStandard.TypeHints.TypeHintDeclaration" does not exist

tester:
Fails to run, : No such file or directory

I was thinking what is your plan? Are you interested in upgrade?

I could do this:

• fix PHPStan issues
• replace Nette tester with PHPUnit 10
• replace slevomat with https://github.com/symplify/coding-standard +https://github.com/rectorphp/rector
• Upgrade to PHP 8.1?
• Extract Client to interface

Thanks and have a good day,