finn-no / bottomsheet Goto Github PK

View Code? Open in Web Editor NEW

354.0 14.0 34.0 388 KB

Custom modal presentation style for thumb-friendly interactive views

License: MIT License

Swift 89.31% Objective-C 0.71% Ruby 9.99%

swift bottomsheet ios

bottomsheet's People

Contributors

Stargazers

Watchers

bottomsheet's Issues

Module name defined for Cocoapods is different than SwiftPM

When we import this module through cocoapods, we import

import FINNBottomSheet

when we do it through SPM we do

import BottomSheet

Then we need to fix this in order to support packages that offer cocoapods and spm integration.

What should be the exported module name?

ping @vadymmarkov

How change HandleView?

Could you add the ability to change handleView? color, visible, remove from super view?

Is there any delegate to keep track of transition of a View ?

[!] Unable to find a specification for `FINNBottomSheet`

[!] Unable to find a specification for FINNBottomSheet

You have either:

out-of-date source repos which you can update with pod repo update or with pod install --repo-update.
mistyped the name or version.
not added the source repo that hosts the Podspec to your Podfile.

Scroll in the BottomSheetView

I have a UITableView in the BottomSheetView. Is there a way to make the scroll of the UITableView work?

Hi, I wanna ask, how to solve this? Thank you

Simulator.Screen.Recording.-.iPhone.12.-.2021-09-22.at.20.19.39.mp4

How to automatically collapse the bottomsheet?

hi~
BottomSheetView can appear successfully
But I want to collapse the bottomsheetView automatically
How can use?
Thanks.

Bottomsheet view width issue when calling another view controller

Hi,
There is a situation like this that I can not find the reason.
Call the bottom sheet screen like this and screenshot first:

    private lazy var bottomSheetTransitioningDelegate = BottomSheetTransitioningDelegate(
        contentHeights: [.bottomSheetAutomatic, 200 ],
        startTargetIndex: 0
    )

 let mViewcontroller = destination(.selectAccount) as! AccountListViewController
        mViewcontroller.contentHeight = 200
        mViewcontroller.transitioningDelegate = bottomSheetTransitioningDelegate
        mViewcontroller.modalPresentationStyle = .custom
        present(mViewcontroller, animated: true, completion: nil)

I call another viewController with the plus button.

      let mViewcontroller = destination(.createAccount) as! NewAccountViewController
        //mViewcontroller.modalPresentationStyle = .fullScreen
        self.present(mViewcontroller, animated: true, completion: nil)

When returning from the newaccount screen with dismiss, the bottom sheet screen looks like this:

It's okay if I don't call it with fullscreen. But when calling as fullscreen, bottomsheet view width changes and viewDidDisappear method is called.
I could not find the reason, I hope you can help.
Thanks a lot.

Not implemented

getting error here

public required init?(coder: NSCoder) {
fatalError("Not implemented")
}

How to resolve this one ? @henrik242 @stigkj @oyvindio @sveisvei @ivarconr

Multiple view controllers

Is it possible to have multiple view controllers at different vertical positions?

SPM Cannot read manifest file

Tried using Swift Package manager to try the sheet.

Seems like the manifest file cannot be parsed.

Swift version: 5.2.4

'init(name:defaultLocalization:platforms:pkgConfig:providers:products:dependencies:targets:swiftLanguageVersions:cLanguageStandard:cxxLanguageStandard:)' is unavailable

Can it support the associated drop-down of the embedded UIScrollView?

Bottomsheet view width issue when calling another view controller

Hi there,

this is the same issue as here: #46

I just modified your demo code in order to reproduce it. You can clone it from here: https://github.com/oskarko/BottomSheetIssue

Just tap in the "view controller" button. and close the new ViewController.

An image:

I have been trying to fix it for a few hours but no luck so fat.

dismiss() not work sometimes

Repeat operation present and dismiss (View Controller button)，but dismiss sometimes not work，touch other element can't any action，

with example project
in DemoViewController.swift / class ViewController / viewDidLoad() add code

let button = UIButton(frame: CGRect(x: 0, y: 0, width: 50, height: 50) )
button.setTitle("tttt", for: .normal)
button.addTarget(self, action: #selector(self.tttt), for: .touchUpInside)
self.view.addSubview(button)

and function

@objc func tttt() {
    self.dismiss(animated: true, completion: nil)
}

console only show

Will dismiss dismiss by nil
Did dismiss dismiss by nil
Will dismiss dismiss by nil

use ios 14.8.1，iphone SE

I missing something?
Any answer help me.
Thanks.

private func showSheet() {
        guard let parentVC = self.parentViewController else {
            return
        }
        let transitioningDelegate = BottomSheetTransitioningDelegate(
            contentHeights: [290, 300],
            startTargetIndex: 0,
            presentationDelegate: self
        )
        let viewController = UIViewController()
        viewController.transitioningDelegate = transitioningDelegate
        viewController.modalPresentationStyle = .custom

        parentVC.present(viewController, animated: true)
    }

and used the delegate like

extension MyView: BottomSheetPresentationControllerDelegate {
    func bottomSheetPresentationController(
        _ controller: UIPresentationController,
        shouldDismissBy action: BottomSheetView.DismissAction
    ) -> Bool {
        return true
    }

    func bottomSheetPresentationController(
        _ controller: UIPresentationController,
        didCancelDismissBy action: BottomSheetView.DismissAction
    ) {

    }

    func bottomSheetPresentationController(
        _ controller: UIPresentationController,
        willDismissBy action: BottomSheetView.DismissAction?
    ) {
    }

    func bottomSheetPresentationController(
        _ controller: UIPresentationController,
        didDismissBy action: BottomSheetView.DismissAction?
    ) {}
}

I'm not sure why it jumps to the top of the parent view controller before dissmiss.

finn-no / bottomsheet Goto Github PK

bottomsheet's People

Contributors

Stargazers

Watchers

Forkers

bottomsheet's Issues

Recommend Projects

Recommend Topics

Recommend Org