finom / deploy-to-git Goto Github PK

You don't want your git token checked into your code... this will allow others to publish to your project.

You should allow for a DEPLOYTOGIT_REPOSITORY environment variable, that way it can be encrypted in yoru travis.yml, or outside your codebase.

After reading the example, I added the required fields but forgot to nest the deployToGit object inside config object (should have been config.deployToGit in package.json).

The error didn't make sense, since it said I was missing "repository", yet I already had two "repository"s in the config - one for the npm general config and one I just added inside deployToGit.

Error I got:

$ deploy-to-git
<pkg>/node_modules/deploy-to-git/index.js:23
        throw Error(`deployToGit requires "${field}" field in package config`);
        ^

Error: deployToGit requires "repository" field in package config
    at Object.<anonymous> (<pkg>/node_modules/deploy-to-git/index.js:23:15)
    at Module._compile (module.js:660:30)
    ...

A simple fix might be this:

diff --git a/index.js b/index.js
index 37c923d..71aefcc 100755
--- a/index.js
+++ b/index.js
@@ -20,7 +20,7 @@ for (const [field, isRequired] of entries(fields)) {
     const configVar = process.env[`${variablePrefix}${field}`];
 
     if (!configVar && isRequired) {
-        throw Error(`deployToGit requires "${field}" field in package config`);
+        throw Error(`Package config is missing required field: "config.deployToGit.${field}"`);
     }

Then, error message is a bit more clear:

Error: Package config is missing required field: "config.deployToGit.repository"
    at Object.<anonymous> ...

(Or, to keep closer to original message, just change "${field}" to "config.deployOnGit.${field}")

Is it possible to tag the commit with version number?

Hello,

I'm trying to use your module on
npm 3.10.10
visual studio code : powershell terminal
Windows 10

I have use the script normally, it clone and build perfectly.
But it doesn't execute any "execSync" starting with blank line.

The only way for me to make it work perfectly is to put everything on the same line.

Exemple if I want "push" to work I must change :

execSync(`
    cd ${config.folder} &&
    git push --tags ${config.repository} ${config.branch}
`, { cwd });

to :

execSync('cd ${config.folder} && git push --tags ${config.repository} ${config.branch}', { cwd });

anyway, thanks you for you job ;)