finschia / wasmd Goto Github PK

This project forked from cosmwasm/wasmd

Basic cosmos-sdk app with web assembly smart contracts

License: Other

Shell 1.24% Go 97.85% Makefile 0.65% Dockerfile 0.25%

wasmd's Introduction

Finschia

This repository hosts Finschia. This repository is forked from gaia at 2021-03-15. Finschia is a mainnet app implementation using finschia-sdk, ostracon, wasmd and ibc-go.

Node: Requires Go 1.20+

Warnings: Initial development is in progress, but there has not yet been a stable.

Quick Start

Docker

Build Docker Image

make docker-build                # build docker image

make docker-build WITH_CLEVELDB=yes GITHUB_TOKEN=${YOUR_GITHUB_TOKEN}  # build docker image with cleveldb

Note1

If you are using M1 mac, you need to specify build args like this:

make docker-build ARCH=arm64

Configure

sh init_single.sh docker          # prepare keys, validators, initial state, etc.

sh init_single.sh docker testnet  # prepare keys, validators, initial state, etc. for testnet

Run

docker run -i -p 26656:26656 -p 26657:26657 -v ${HOME}/.finschia:/root/.finschia finschia/finschianode fnsad start

Local

Build

make build
make install

Configure

sh init_single.sh

sh init_single.sh testnet  # for testnet

Run

fnsad start                # Run a node

visit with your browser

Node: http://localhost:26657/

Localnet with 4 nodes

Run

make localnet-start

Stop

make localnet-stop

How to contribute

check out CONTRIBUTING.md for our guidelines & policies for how we develop Finschia. Thank you to all those who have contributed!

wasmd's People

Contributors

Stargazers

Forkers

zemyblue ryu1-sakai tnasu shiki-tak loin3 jaeseung-bae da1suk8 kokeshim0chi

wasmd's Issues

bug: wrap result twice

wasmd/x/wasmplus/handler.go

Line 33 in d08bbbd

return sdk.WrapServiceResult(ctx, res, err)

This code wraps the result which is already wrapped. It is a bug.

dependency

cosmwasm/wasmvm: v1.2.0
cosmwasm/cosmwasm-std: v1.0-1.2

Check the authorization to active/inactive contracts is not within the scope of x/wasmplus or not

This issue related to #43

Check the x/wasmplus authority for active/inactive specifications.

Change error message when inactive in callCallablePoint

Make it easy to understand Inactive

wasmd/x/wasmplus/keeper/api.go

Lines 25 to 27 in d6ea9ec

 if a.keeper.IsInactiveContract(*a.ctx, contractAddr) { 

 return nil, 0, fmt.Errorf("called contract cannot be executed") 

 }

Redesign `callablePointSDKEventAttributes` function

This function came from #26.

It's a bit weird that the callstack comes first, so move it to the tail.

wasmd/x/wasmplus/keeper/events.go

Lines 42 to 50 in d6ea9ec

 func callablePointSDKEventAttributes(customAttributes []wasmvmtypes.EventAttribute, contractAddr sdk.AccAddress, callstack []byte) ([]sdk.Attribute, error) { 

 attrs, err := wasmkeeper.ContractSDKEventAttributes(customAttributes, contractAddr) 

 if err != nil { 

 return nil, err 

 } 

 // attrs[0] is addr 

 attrs = append([]sdk.Attribute{attrs[0], sdk.NewAttribute(wasmplustypes.AttributeKeyCallstack, string(callstack))}, attrs[1:]...) 

 return attrs, nil 

 }

Not good condition to handle MsgStoreCodeAndInstantiateContract

wasmd/x/wasmplus/handler.go

Line 26 in d08bbbd

 if err != nil && strings.Contains(err.Error(), "MsgStoreCodeAndInstantiateContract") { 

This handler case is caused by "x/wasm/handler"'s "ErrorMsg". This condition is true when the message contains "MsgStoreCodeAndInstantiateContract" even if the message kind is not "MsgStoreCodeAndInstantiateContract".

Change it the condition is true iff the message kind is "MsgStoreCodeAndInstantiateContract".

bump up to cosmwasm/wasmd v0.30.0

Propose methods to completely separate the functions of dynamic_link into wasmplus

At present #22, only partial separation has been made for dynamic link branch of wasmd, so consider how to do this.

The following methods were used for implementation.

In #36, moved dynamic_link branch functionality to wasmplus.

It is implemented in the following way.

Define the interface of the function defined in x/wasmplus/keeper.go in x/wasm/keeper.go.
In x/wasm, functions and variables to be exposed to the outside world are defined as other variables in exported_*.go, in order to reduce differences from the original.
Access the functions defined in x/wasmplus/api.go via the interface in x/wasm/keeper.go.

Refactoring so that it can be implemented like a higher-order function without using `coswasmAPIImpl`

Since cosmwasmAPIGeneratorImpl was added in #41, and it is not good that cosmwasmAPIImpl and cosmwasmAPIGeneratorImpl coexist, I think it would be better to abolish cosmwasmAPIImpl and define it as a higher-order function and use that.　

wasmd/x/wasmplus/keeper/api.go

Lines 13 to 16 in d6ea9ec

 type cosmwasmAPIImpl struct { 

 keeper *Keeper 

 ctx *sdk.Context 

 }

Add a test handling other than "StoreCodeAndInstantiateContract" in wasmplus

There are no test handling messages other than "StoreCodeAndINstantiateContract" in wasmplus.
related #33

TestExecuteManualInactiveContractFailure does not check whether the contract is active or not

wasmd/x/wasm/keeper/keeper_test.go

Lines 1722 to 1748 in c23a2db

 func TestExecuteManualInactiveContractFailure(t *testing.T) { 

 ctx, keepers := CreateTestInput(t, false, AvailableCapabilities) 

 keeper := keepers.ContractKeeper 

 deposit := sdk.NewCoins(sdk.NewInt64Coin("denom", 100000)) 

 topUp := sdk.NewCoins(sdk.NewInt64Coin("denom", 5000)) 

 creator := keepers.Faucet.NewFundedRandomAccount(ctx, deposit...) 

 fred := keepers.Faucet.NewFundedRandomAccount(ctx, topUp...) 

 wasmCode, err := os.ReadFile("./testdata/hackatom.wasm") 

 require.NoError(t, err) 

 contractID, _, err := keeper.Create(ctx, creator, wasmCode, nil) 

 require.NoError(t, err) 

 _, _, bob := keyPubAddr() 

 initMsg := HackatomExampleInitMsg{ 

 Verifier: fred, 

 Beneficiary: bob, 

 } 

 initMsgBz, err := json.Marshal(initMsg) 

 require.NoError(t, err) 

 addr, _, err := keeper.Instantiate(ctx, contractID, creator, nil, initMsgBz, "demo contract 3", deposit) 

 require.NoError(t, err) 

 require.Equal(t, "link14hj2tavq8fpesdwxxcu44rty3hh90vhujrvcmstl4zr3txmfvw9sgf2vn8", addr.String()) 

 }

Add `wasmvm.GoAPI` field to the keeper structure

The method #36 cannot be executed in x/wasm alone, because it uses the x/wasmplus functionality within x/wasm.

Then, instead of pluskeeper, which was added in #36, add an interface of wasmvm.GoAPI to the structure of keeper.
This allows the implementation of this interface to freely change the contents of the API.

Enable the use of wasmplus's `IsInactiveContract()` in cosmwasmAPI

In the dynamic_link branch separated process, the following function of wasmplus cannot be used in the #22 separated method due to circular reference problems.

Separation must be done by another method

wasmd/x/wasmplus/keeper/keeper.go

Lines 93 to 96 in 60fec8a

 func (k Keeper) IsInactiveContract(ctx sdk.Context, contractAddress sdk.AccAddress) bool { 

 store := ctx.KVStore(k.storeKey) 

 return store.Has(types.GetInactiveContractKey(contractAddress)) 

 }

update license

line -> finschia

apply the changes of `line/ibc-go#6`(change to use 07-tendermint)

The Ostracon's light client name is changed for ibc in last line/igc-go (Finschia/ibc-go#6).
So wasmd also need to bump up.

The used light-client name is changed

99-ostracon -> 07-tendermint

wasmvm module not exist

When I run wasmd start, wasmvm module not exist error is occurred.

$ ./build/wasmd start
Error: wasmvm module not exist
Usage:
  wasmd start [flags]

commit hash: 577e450 (main branch)

detach custom genesis and types as lbm proto

inactive_contract_address of message genesis and gans_multiplier of message Params are all custom changes. So we need to remove in cosmwas, proto and add to custom genensis and params in lbm proto.

https://github.com/line/wasmd/blob/cae21ecd251cea44f56209e0a4586ca2979c6c87/proto/cosmwasm/wasm/v1/genesis.proto#L29

https://github.com/line/wasmd/blob/cae21ecd251cea44f56209e0a4586ca2979c6c87/proto/cosmwasm/wasm/v1/types.proto#L52-L54

Add benchmarks to CI

Summary

In dynamic_link branch, https://github.com/line/lbm-sdk/blob/dynamic_link/.github/workflows/bench.yml benchmarks cosmwasm API for each PRs. I suggest adding other benchmarks to the workflow following this.

There are some problems in my naive trying (https://github.com/line/lbm-sdk/runs/8133107470?check_suite_focus=true)

For Admin Use

Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged
Contributor assigned/self-assigned

MsgStoreCodeAndInstantiateContract amino signature verify fail

MsgStoreCodeAndInstantiateContract amino signature verify fails because wrong amino codec is being used in MsgStoreCodeAndInstantiateContract::GetSignBytes(). Now wasm's amino codec is being used not wasmplus's amino codec.
https://github.com/line/wasmd/blob/main/x/wasmplus/types/tx.go#L54

And I got one more error.
https://github.com/line/wasmd/blob/main/x/wasmplus/types/codec.go#L19
when registering amino msg in codec, amino message type name is wrong.
currently "wasm/StoreCodeAndInstantiateContract", this should be "wasm/MsgStoreCodeAndInstantiateContract" like other messages.

change depending wasmvm's URL

replace github.com/line with github.com/Finschia

Research about standard interface detection.

Summary

Research about standard interface detection.

Research on function that can replace EVM's function selector.
Defining standard interface detection protocol.
Suggest a way to use an external library like inheritance from wasm.

Problem Definition

We need to know whether a specific smart contract supports a specific protocol, so that the smart contract can be excute and searched without errors in other smart contracts. For this purpose, in the case of EVM, the function of a function selector is provided. Let's see if there is a function that can replace EVM's function selector function that can distinguish a specific function from the wasm binary even in wasm of lbm-sdk.

If that feature doesn't exist, find out how to replace it.

Inheritance is not supported like EVM throught rustlang, the smart contract development language of cosmwasm. Then, we also suggest how to make a protocol such as ERC-165 a library so that other smart contract developers can use it.

For Admin Use

Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged
Contributor assigned/self-assigned

need to backport lbm-sdk#853

lbm-sdk#854 is that remove useless stub BeginBlock/EndBlock methods

	if a.keeper.IsInactiveContract(*a.ctx, contractAddr) {
	return nil, 0, fmt.Errorf("called contract cannot be executed")
	}

	func callablePointSDKEventAttributes(customAttributes []wasmvmtypes.EventAttribute, contractAddr sdk.AccAddress, callstack []byte) ([]sdk.Attribute, error) {
	attrs, err := wasmkeeper.ContractSDKEventAttributes(customAttributes, contractAddr)
	if err != nil {
	return nil, err
	}
	// attrs[0] is addr
	attrs = append([]sdk.Attribute{attrs[0], sdk.NewAttribute(wasmplustypes.AttributeKeyCallstack, string(callstack))}, attrs[1:]...)
	return attrs, nil
	}

	type cosmwasmAPIImpl struct {
	keeper *Keeper
	ctx *sdk.Context
	}

	func TestExecuteManualInactiveContractFailure(t *testing.T) {
	ctx, keepers := CreateTestInput(t, false, AvailableCapabilities)
	keeper := keepers.ContractKeeper

	deposit := sdk.NewCoins(sdk.NewInt64Coin("denom", 100000))
	topUp := sdk.NewCoins(sdk.NewInt64Coin("denom", 5000))
	creator := keepers.Faucet.NewFundedRandomAccount(ctx, deposit...)
	fred := keepers.Faucet.NewFundedRandomAccount(ctx, topUp...)

	wasmCode, err := os.ReadFile("./testdata/hackatom.wasm")
	require.NoError(t, err)

	contractID, _, err := keeper.Create(ctx, creator, wasmCode, nil)
	require.NoError(t, err)

	_, _, bob := keyPubAddr()
	initMsg := HackatomExampleInitMsg{
	Verifier: fred,
	Beneficiary: bob,
	}
	initMsgBz, err := json.Marshal(initMsg)
	require.NoError(t, err)

	addr, _, err := keeper.Instantiate(ctx, contractID, creator, nil, initMsgBz, "demo contract 3", deposit)
	require.NoError(t, err)
	require.Equal(t, "link14hj2tavq8fpesdwxxcu44rty3hh90vhujrvcmstl4zr3txmfvw9sgf2vn8", addr.String())
	}

	func (k Keeper) IsInactiveContract(ctx sdk.Context, contractAddress sdk.AccAddress) bool {
	store := ctx.KVStore(k.storeKey)
	return store.Has(types.GetInactiveContractKey(contractAddress))
	}

finschia / wasmd Goto Github PK

wasmd's Introduction

Finschia

Quick Start

Docker

Local

Localnet with 4 nodes

How to contribute

wasmd's People

Contributors

Stargazers

Forkers

wasmd's Issues

dependency

Summary

For Admin Use

Summary

Problem Definition

For Admin Use

Recommend Projects

Recommend Topics

Recommend Org