Giter VIP home page Giter VIP logo

Comments (11)

gforney avatar gforney commented on September 4, 2024

from smv.

obscureed avatar obscureed commented on September 4, 2024

I would have preferred more descriptive names than SMOKEPROP and SMOKEFIREPROP -- SMOKE3DEXTINCTION, for example.

from smv.

gforney avatar gforney commented on September 4, 2024

wanted to leave open the option of adding other smoke or fire properties if needed to these keywords.

from smv.

obscureed avatar obscureed commented on September 4, 2024

From my perspective as a user, descriptive names are helpful. If a new smoke property is added, it is helpful if it is given a new descriptive name, rather than lumped with unrelated numbers into one catchall name. I sometimes have to hunt through the .ini file for a relevant-sounding parameter name, and then experiment with it to see if it does what I want. The documentation does not describe all the relevant parameters -- it does not currently mention SMOKEPROP or SMOKEFIREPROP, for example.

from smv.

gforney avatar gforney commented on September 4, 2024

should be fixed in smokeview posted here
https://drive.google.com/drive/folders/0B_wB1pJL2bFQc1F4cjJWY2duWTA?resourcekey=0-J_yHat7iJoBp1fk6QS8gMA&usp=sharing

from smv.

gforney avatar gforney commented on September 4, 2024

did the smokeview I posted fix your issue?

from smv.

obscureed avatar obscureed commented on September 4, 2024

Sorry, it will be a few days before I have time to test this.

from smv.

obscureed avatar obscureed commented on September 4, 2024

I've tried that test version of smokeview on the test case I posted. The three .ini files are all different from each other in various ways, which I find slightly odd. In particular, step4.ini is missing the settings of SMOKEFIREPROP that are present in the earlier step2.ini and step3.ini. Can it be correct that displaying some results destroys a setting? Even so, the .ini files are not garbled, so I'll mark this as closed. Thanks for your efforts!

from smv.

obscureed avatar obscureed commented on September 4, 2024

Reopening because I think there are a couple of similar missing '\n' issues in saved .ini files:
• end of numeric line after "CO2COLOR" (or start of DIRECTIONCOLOR)
• end of numeric line after "SHOWHRRPLOT" (or start of SHOWMISSINGOBJECTS)

I haven't seen any problems because of these, so I'm just highlighting for info. No need from me for a patched version, thanks.

from smv.

gforney avatar gforney commented on September 4, 2024

from smv.

obscureed avatar obscureed commented on September 4, 2024

Great, thanks. I've verified the patched version and am closing the issue.

from smv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.