Giter VIP home page Giter VIP logo

profundis's People

Contributors

firenh avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

profundis's Issues

Amethyst Caves biome uses `minecraft:music.overworld.jungle_and_forest` which was removed in 1.20

The amethyst caves biome JSON specifies the music sound event as minecraft:music.overworld.jungle_and_forest:

"music": {
"max_delay": 24000,
"min_delay": 12000,
"replace_current_music": false,
"sound": "minecraft:music.overworld.jungle_and_forest"
},

However, this does not exist in 1.20. According to a brief search in Linkie, it seems to have existed in 1.19.4 then removed in 1.20:

In 1.19.4:

image

In 1.20 (and onwards):

image

Due to vanilla's poor codec handling, this field being invalid does not error, as the music field is an optional field. When used with Cyanide, however, this gets promoted to a full error:

[23:16:10] [Render thread/WARN] (Minecraft) Failed to load level data or datapacks, can't proceed with server load
java.util.concurrent.ExecutionException: java.lang.IllegalStateException: Error(s) loading registries:


Errors(s) loading registry minecraft:worldgen/biome:

Optional field "music" was invalid: Failed to get element ResourceKey[minecraft:sound_event / minecraft:music.overworld.jungle_and_forest]
	at: "effects"
	at: worldgen/biome 'profundis:worldgen/biome/amethyst_caves.json'
	at: pack 'fabric'


Errors occurred freezing registries.
These were elements that were referenced, but never defined (or their definition had an error above).

Missing references from the worldgen/biome registry: [
	'profundis:amethyst_caves'
]

This was reported as an issue to Cyanide here: alcatrazEscapee/cyanide#23

Arid caves

there should be an arid biome where there is sand on the ground and the walls of the cave are made out of sandstone

it crashes

this is what it said

[14:51:11] [Render thread/ERROR]: [net.minecraft.class_310#method_1514] Reported exception thrown!
net.minecraft.util.crash.CrashException: mouseClicked event handler
	at net.minecraft.client.gui.screen.Screen.wrapScreenError(Screen.java:414) ~[client-intermediary.jar:?]
	at net.minecraft.client.Mouse.onMouseButton(Mouse.java:98) ~[client-intermediary.jar:?]
	at net.minecraft.client.Mouse.method_22686(Mouse.java:169) ~[client-intermediary.jar:?]
	at net.minecraft.util.thread.ThreadExecutor.execute(ThreadExecutor.java:102) ~[client-intermediary.jar:?]
	at net.minecraft.client.Mouse.method_22684(Mouse.java:169) ~[client-intermediary.jar:?]
	at org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:43) ~[lwjgl-glfw-3.3.1.jar:?]
	at org.lwjgl.system.JNI.invokeV(Native Method) ~[lwjgl-3.3.1.jar:?]
	at org.lwjgl.glfw.GLFW.glfwWaitEventsTimeout(GLFW.java:3474) ~[lwjgl-glfw-3.3.1.jar:?]
	at com.mojang.blaze3d.systems.RenderSystem.limitDisplayFPS(RenderSystem.java:237) ~[client-intermediary.jar:?]
	at net.minecraft.client.MinecraftClient.render(MinecraftClient.java:1244) ~[client-intermediary.jar:?]
	at net.minecraft.client.MinecraftClient.run(MinecraftClient.java:802) ~[client-intermediary.jar:?]
	at net.minecraft.client.main.Main.main(Main.java:250) ~[minecraft-1.20.1-client.jar:?]
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:468) ~[fabric-loader-0.14.22.jar:?]
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) ~[fabric-loader-0.14.22.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) ~[fabric-loader-0.14.22.jar:?]
	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:88) ~[NewLaunch.jar:?]
	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:126) ~[NewLaunch.jar:?]
	at org.prismlauncher.EntryPoint.main(EntryPoint.java:71) ~[NewLaunch.jar:?]
Caused by: java.lang.IllegalStateException: Error(s) loading registries:


Errors(s) loading registry minecraft:worldgen/biome:

Optional field "music" was invalid: Failed to get element ResourceKey[minecraft:sound_event / minecraft:music.overworld.jungle_and_forest]
	at: "effects"
	at: worldgen/biome 'profundis:worldgen/biome/amethyst_caves.json'
	at: pack 'fabric'


Errors occurred freezing registries.
These were elements that were referenced, but never defined (or their definition had an error above).

Missing references from the worldgen/biome registry: [
	'profundis:amethyst_caves'
]


	at com.alcatrazescapee.cyanide.codec.MixinHooks.loadAllRegistryData(MixinHooks.java:137) ~[cyanide-fabric-1.20-4.0.0.jar:?]
	at net.minecraft.registry.RegistryLoader.handler$cff000$cyanide$loadAndReportErrors(RegistryLoader.java:1519) ~[client-intermediary.jar:?]
	at net.minecraft.registry.RegistryLoader.load(RegistryLoader.java) ~[client-intermediary.jar:?]
	at net.minecraft.server.SaveLoading.loadDynamicRegistryManager(SaveLoading.java:67) ~[client-intermediary.jar:?]
	at net.minecraft.server.SaveLoading.withRegistriesLoaded(SaveLoading.java:71) ~[client-intermediary.jar:?]
	at net.minecraft.server.SaveLoading.load(SaveLoading.java:34) ~[client-intermediary.jar:?]
	at net.minecraft.client.gui.screen.world.CreateWorldScreen.create(CreateWorldScreen.java:333) ~[client-intermediary.jar:?]
	at net.minecraft.client.gui.screen.world.WorldListWidget.loadLevels(WorldListWidget.java:169) ~[client-intermediary.jar:?]
	at net.minecraft.client.gui.screen.world.WorldListWidget.<init>(WorldListWidget.java:95) ~[client-intermediary.jar:?]
	at net.minecraft.client.gui.screen.world.SelectWorldScreen.init(SelectWorldScreen.java:54) ~[client-intermediary.jar:?]
	at net.minecraft.client.gui.screen.Screen.init(Screen.java:297) ~[client-intermediary.jar:?]
	at net.minecraft.client.MinecraftClient.setScreen(MinecraftClient.java:1080) ~[client-intermediary.jar:?]
	at net.minecraft.client.gui.screen.TitleScreen.method_19861(TitleScreen.java:159) ~[client-intermediary.jar:?]
	at net.minecraft.client.gui.widget.ButtonWidget.onPress(ButtonWidget.java:94) ~[client-intermediary.jar:?]
	at net.minecraft.client.gui.widget.PressableWidget.onClick(PressableWidget.java:56) ~[client-intermediary.jar:?]
	at net.minecraft.client.gui.widget.ClickableWidget.mouseClicked(ClickableWidget.java:189) ~[client-intermediary.jar:?]
	at net.minecraft.client.gui.ParentElement.mouseClicked(ParentElement.java:38) ~[client-intermediary.jar:?]
	at net.minecraft.client.gui.screen.TitleScreen.mouseClicked(TitleScreen.java:299) ~[client-intermediary.jar:?]
	at net.minecraft.client.Mouse.method_1611(Mouse.java:98) ~[client-intermediary.jar:?]
	at net.minecraft.client.gui.screen.Screen.wrapScreenError(Screen.java:409) ~[client-intermediary.jar:?]
	... 17 more

https://gist.github.com/stunlocked1/7417f26334ae1e9f5b98b7fb66278b0c

Incompatibility with Tectonic / Terralith

Not sure which one, assumed it would be Tectonic but I’ve heard of a similar problem with Terralith. Issue on 1.20 Fabric, would greatly appreciate it if compatibility could be looked into.

1.5.2 is not compatible with fabric 1.20

I am given an incompatible mod set error when I try to run 1.5.2 on fabric.
I have another worldgen mod installed called Hybrid beta, in case that's important.

Log Spam When Generating Terrain

Hi, love the mod! Wish there were more mods out there that add new Cave Biomes!

Whenever I generate a world and/or generate new chunks, my console spams the following:

[16:17:48] [Render thread/INFO]: Preparing spawn area: 62%
[16:17:48] [Worker-Main-11/INFO]: placements: 1
[16:17:48] [Worker-Main-11/INFO]: placements: 1
[16:17:48] [Worker-Main-11/INFO]: placements: 2
[16:17:48] [Worker-Main-11/INFO]: placements: 3
[16:17:48] [Worker-Main-11/INFO]: placements: 4
[16:17:48] [Worker-Main-11/INFO]: placements: 5
[16:17:48] [Worker-Main-11/INFO]: placements: 6
[16:17:48] [Worker-Main-11/INFO]: placements: 7
[16:17:48] [Worker-Main-11/INFO]: placements: 8
[16:17:48] [Worker-Main-11/INFO]: placements: 9
[16:17:48] [Worker-Main-11/INFO]: placements: 10
[16:17:48] [Worker-Main-11/INFO]: placements: 11
[16:17:48] [Worker-Main-11/INFO]: placements: 12
[16:17:48] [Worker-Main-11/INFO]: placements: 13
[16:17:48] [Worker-Main-11/INFO]: placements: 14
[16:17:48] [Worker-Main-11/INFO]: placements: 15
[16:17:48] [Worker-Main-11/INFO]: placements: 16
[16:17:48] [Worker-Main-11/INFO]: placements: 17
[16:17:48] [Worker-Main-11/INFO]: placements: 18
[16:17:48] [Worker-Main-11/INFO]: placements: 19
[16:17:48] [Worker-Main-11/INFO]: placements: 20
[16:17:48] [Worker-Main-11/INFO]: placements: 21
[16:17:48] [Worker-Main-11/INFO]: placements: 22
[16:17:48] [Worker-Main-11/INFO]: placements: 23
[16:17:48] [Worker-Main-11/INFO]: placements: 24
[16:17:48] [Worker-Main-11/INFO]: placements: 25
[16:17:48] [Worker-Main-11/INFO]: placements: 26
[16:17:48] [Worker-Main-11/INFO]: placements: 27
[16:17:48] [Worker-Main-11/INFO]: placements: 28
[16:17:48] [Worker-Main-11/INFO]: placements: 29
[16:17:48] [Worker-Main-11/INFO]: placements: 30
[16:17:48] [Worker-Main-11/INFO]: placements: 31
[16:17:48] [Worker-Main-11/INFO]: placements: 32
[16:17:48] [Worker-Main-11/INFO]: placements: 33
[16:17:48] [Worker-Main-11/INFO]: placements: 34
[16:17:48] [Worker-Main-11/INFO]: placements: 35
[16:17:48] [Worker-Main-11/INFO]: placements: 36
[16:17:48] [Worker-Main-11/INFO]: placements: 37
[16:17:48] [Worker-Main-11/INFO]: placements: 38
[16:17:48] [Worker-Main-11/INFO]: placements: 39
[16:17:48] [Worker-Main-11/INFO]: placements: 40
[16:17:48] [Worker-Main-11/INFO]: placements: 41
[16:17:48] [Worker-Main-11/INFO]: placements: 42
[16:17:48] [Worker-Main-11/INFO]: placements: 43
[16:17:48] [Worker-Main-11/INFO]: placements: 44
[16:17:48] [Worker-Main-11/INFO]: placements: 45
[16:17:48] [Worker-Main-11/INFO]: placements: 46
[16:17:48] [Worker-Main-11/INFO]: placements: 47
[16:17:48] [Render thread/INFO]: Preparing spawn area: 64%

I tested without Profundis and the log spam went away, leading me to believe Profundis is the culprit

Incompatible with Terralith/WWOO and probably other biome mods

Tested with
MC: 1.20.1
Fabric: 0.14.22
Terralith: 2.4.5
WWOO: 3.2.1
Profundis: 1.6.0

The game does not crash, no errors in the log, but no structures/biomes from Profundis generate.

I'd love to use this mod for some cave biomes alongside other biome mods, any change we could get a compatibility patch?

may we have the updated version (1.5.1) for the 1.19.2?

the reason is that the current version available for 1.19.2 has some annoying bugs that makes not too viable to play with the mod, and basically all of those bugs were fixed on the newer versions.
and also, thank you for the awesome mod, im looking forward for the next updates!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.