Test macOS, Windows builds on pull-requests about fish-food HOT 5 CLOSED

Please feel free to look into this. I’m on holiday break.

from fish-food.

There are some issues with getting gofish tank working in the Linux subsystem because it's not evalable.

huh? It was designed to be eval-able.eval is the primary use case for gofish tank.

Easiest way to handle this is regex for os = "darwin". Any good alternatives?

You could try catching that error message and exit if another error message is found.

from fish-food.

Is something you would be interested in entertaining @bacongobbler? If not I can close it. nbd. i can PR the changes if you're cool with it.

from fish-food.

Like most things I under estimated how much work this could be. Couple of issues I've experienced:

1. Obvious differences between pwsh and bash. Should we use pwsh for Windows or just bash on all platforms? There are some issues with getting gofish tank working in the Linux subsystem because it's not evalable.
2. We need a way to determine if the Food supports the current architecture/platform. gofish will return 1 if you try to gofish install vagrant on Darwin for example. Easiest way to handle this is regex for os = "darwin". Any good alternatives?

from fish-food.

huh? It was designed to be eval-able.eval is the primary use case for gofish tank.

Ya, but in Windows' Linux Subsystem and with bash, eval $env.GOFISH_HOME won't work as gofish tank throws out pwsh, not sh. Would need export style script.

If the Windows tests are to be completely in pwsh (and not using bash/subsystem), gofish.exe tank | iex works juuuust fine 🙂 If we want to use bash in Windows we'll need some sort of alternative to export the env vars.

As an aside, perhaps gofish tank should be shell aware and throw out export in bash on Windows?

You could try catching that error message and exit if another error message is found.

trap?

from fish-food.