Giter VIP home page Giter VIP logo

fish-food's People

Contributors

arbourd avatar bacongobbler avatar bootswithdefer avatar chifu1234 avatar clakeb avatar digitalsparky avatar duffn avatar fmotrifork avatar ga-paul-t avatar gofish-bot avatar hairyhenderson avatar jackfrancis avatar jdolitsky avatar johnnygenomics avatar jreleaserbot avatar karuppiah7890 avatar linuxsuren avatar mboersma avatar melachosangfleg avatar mogensen avatar nicdoye avatar nikaro avatar nousefreak avatar oliverbaehler avatar scranton avatar seekingmeaning avatar soloio-bot avatar vdice avatar yjuns avatar yosbeleg89 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

fish-food's Issues

Error when use gofish install cli

when I use GoFish install jcli plugin on windows 10 environment:
PS C:\WINDOWS\system32> gofish.exe init
The following new directories will be created:
C:\ProgramData\Fish
C:\ProgramData\Fish\Barrel
C:\ProgramData\Fish\Rigs
C:\ProgramData\bin
C:\Users\SyJun\AppData\Local\Fish
==> Installing default fish food...
Error: Unable to get repository: Cloning into 'C:\ProgramData\Fish\Rigs\github.com\fishworks\fish-food'...
fatal: Invalid path '/cygdrive/c/WINDOWS/system32/C:\ProgramData\Fish\Rigs\github.com\fishworks\fish-food': No such file or directory
: exit status 128
PS C:\WINDOWS\system32> gofish.exe update
==> Rigs updated!
NAME

๐Ÿ  rigs updated in 1.0011ms
PS C:\WINDOWS\system32> gofish install jcli
Error: no fish food with the name 'jcli' was found

Escape `@<username>` mentions in PRs produced by bot

While I am much supportive of (and very happy with) the automated distribution of the goods we produce, the behavior of the bot to copy and paste the release notes including @<username> mentions creates a lot of noise in my already hard to track notifications.

It would therefore be awesome if the bot could detect and modify username mentions, so that I no longer receive pings for something that is out of my hands.

The best way to do this at present is described in: github/markup#1168 (comment)

Test macOS, Windows builds on pull-requests

Right now the Github Actions CI only tests against a Linux install. This allows PRs that work for Linux to pass, but maybe issues like #1122 to arise with other platforms.

Should we tests against the other platforms? Future CI could look like:

  1. step: gofish lint
  2. if 1. passes, matrix gofish install on all platforms

This would make all builds longer, and requires the downloading of assets twice (once for the lint step, again for the install step -- this could be fixed with asset caching), but would ensure that all platforms have installable binaries.

CI: only test food that has changed in a PR

I would propose reimplementing the Circle CI tests on PRs, so that only the foods that has been changed is tested.
This could help us in actually identifying which PRs are good and which are bad.

If we still want to validate all foods on a regular basis this could be done with a weekly report/alert?

GoFish-bot for updating fish food

Hi,

I have started developing a bot that can create pull-requests when existing fish food gets new releases.

For now it is still quite simple and rough around the edges.
I will make the code open-source, when i have added a few safe guards.
It still needs to learn to only create pull requests for new releases, and not open multiple PRs for the same package/release multiple times.. ;)

https://github.com/gofish-bot

So this is just a heads-up that GoFish-bot will start trying to be an active contributor to the fish-food repo. ๐Ÿ˜„ ๐Ÿค–

Problem upgrading Linkerd that does not follow Semantic Versioning

There's currently a problem in upgrading the linkerd food.

The problem seems to be that the version, that Linkerd published, does not follow Semantic Versioning.

$ gofish update && gofish upgrade
==> Rigs updated!
NAME                          
github.com/fishworks/fish-food

๐Ÿ   rigs updated in 6.333312243s
==> Rigs updated!
NAME                          
github.com/fishworks/fish-food

๐Ÿ   rigs updated in 2.458226787s
==> Upgrading buffalo...
๐Ÿ   buffalo 0.16.10: upgraded in 32.57126ms
Error: Error parsing version: Invalid Semantic Version

I see a couple of problems here that I think should be addressed:

  • Linkerd food is broken.
  • It is not possible to identify from the error message which food is actually the problem.
  • The Linkerd lints and installs fine, but does not work when upgrading.

I can create a new PR with a better version, but I think that this may also require some cleanup on machines where the Linkerd Food is installed?

Add info about uff in Readme

I recently created a new tool called uff - update fish food. It's a small and bit hacky tool to update a gofish food that I used to raise some PRs recently.

Anyone can use the tool to update the fish food with ease, in most cases. So I thought may be we can mention it in the readme so that if anyone wants to raise a PR it's just very easy and automated too

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.