The telegram-bot-simple from fizruk

Version 6.0 won't compile

Trying to compile the latest version from github.
Getting this errors:

telegram-bot-simple/src/Telegram/Bot/API/Types.hs:563:65: error:
   • No instance for (ToJSON WebAppInfo) arising from a use of ‘.=’
   • In the expression: "web_app_info" .= wai
     In the second argument of ‘addType’, namely
       ‘["text" .= txt, "web_app_info" .= wai]’
     In the second argument of ‘($)’, namely
       ‘addType "web_app" ["text" .= txt, "web_app_info" .= wai]’
   |                              
563 |       object $ addType "web_app" ["text" .= txt, "web_app_info" .= wai]
   |                                                                 ^^
                                  
/telegram-bot-simple/src/Telegram/Bot/API/Types.hs:571:15: error:
   • No instance for (FromJSON WebAppInfo)
       arising from a use of ‘gparseJSON’
   • In the expression: gparseJSON
     In an equation for ‘parseJSON’: parseJSON = gparseJSON
     In the instance declaration for ‘FromJSON MenuButton’
   |                              
571 |   parseJSON = gparseJSON

stack ghc -- --version
The Glorious Glasgow Haskell Compilation System, version 9.0.1

stack --version
Version 2.7.3, Git revision 7927a3aec32e2b2e5e4fb5be76d0d50eddcc197f x86_64 hpack-0.34.4

• Added support for Web Apps.
• KeyboardButton and InlineKeyboardButton can now be used to launch Web Apps.
• Added control over the bot's menu button via setChatMenuButton and getChatMenuButton.
• Added control over the bot's default admin rights via setMyDefaultAdministratorRights and getMyDefaultAdministratorRights.
• Added support for t.me links to add bots as admins.

• And more, see the full changelog for details:

https://core.telegram.org/bots/api-changelog#april-16-2022

Warning: After the next update, login_url will only allow HTTPS links.

Notification in send document can't be disabled

Even if we set sendDocumentDisableNotification = Just True, the message is still sent with notification.

How to reproduce:

Send document without notifications:

      defaultRunBot (fromString token) $
        sendDocument
          (toSendDocument
             chat_id
              (DocumentFile archive_path "application/zip"))
                { sendDocumentCaption = Just "some caption.zip")
                , sendDocumentDisableNotification = Just True
                }

Expected results:

Message will be delivered without notification. There will be strikethrough bell icon near the message.

Actual results:

Message is delivered with notifications

stack build fails with No instance for (MonadFail UpdateParser)

No instance for (MonadFail UpdateParser)/home/vyorkin/projects/github/haskell/telegram-bot-simple/src/Telegram/Bot/Simple/UpdateParser.hs:43:10: error:
    • No instance for (MonadFail UpdateParser)
        arising from a use of ‘fail’
    • In the expression: fail "command"
      In a stmt of a 'do' block:
        if "/" `Text.isPrefixOf` t then fail "command" else pure t
      In the expression:
        do t <- text
           if "/" `Text.isPrefixOf` t then fail "command" else pure t
   |
43 |     then fail "command"
   |          ^^^^^^^^^^^^^^

Maybe this is because the instance was accidentally deleted cbe7f38#diff-578fc2ec77b209d8f0088375d3801054L30-L32

Bot can't parse message with $CASHTAG

Hello!
If message contains a cashtag:
https://core.telegram.org/tdlib/docs/classtd_1_1td__api_1_1text_entity_type_cashtag.html
it will causes an error:
DecodeFailure "Error in $.result[0].message['reply_to_message'].entities[0].type: The key "cashtag" was not found".

Payments: Bot API 5.5

https://core.telegram.org/bots/api#payments

Types

LabeledPrice: https://core.telegram.org/bots/api#labeledprice
Invoice: https://core.telegram.org/bots/api#invoice
ShippingAddress: https://core.telegram.org/bots/api#shippingaddress
OrderInfo: https://core.telegram.org/bots/api#orderinfo
ShippingOption: https://core.telegram.org/bots/api#shippingoption
SuccessfulPayment: https://core.telegram.org/bots/api#successfulpayment
ShippingQuery: https://core.telegram.org/bots/api#shippingquery
PreCheckoutQuery: https://core.telegram.org/bots/api#precheckoutquery

Methods

sendInvoice: https://core.telegram.org/bots/api#sendinvoice
answerShippingQuery: https://core.telegram.org/bots/api#answershippingquery
answerPreCheckoutQuery: https://core.telegram.org/bots/api#answerprecheckoutquery

GHC 9 Compilation failure

Building library for telegram-bot-simple-0.3.5..               
                                                                                                                                                                                           
src/Telegram/Bot/API/Types.hs:436:1: error:
    • No instance for (FromJSON ChatPhoto)
        arising from a use of ‘parseJSON’
    • In the first argument of ‘Data.Aeson.TH.lookupField’, namely
        ‘parseJSON’
      In the second argument of ‘(<*>)’, namely
        ‘((((Data.Aeson.TH.lookupField parseJSON)
              "Telegram.Bot.API.Types.Chat")
             "")
            recObj_akPn)
           (pack "photo")’
      In the first argument of ‘(<*>)’, namely
        ‘((((((((Chat
                   <$>
                     ((((Data.Aeson.TH.lookupField parseJSON)
                          "Telegram.Bot.API.Types.Chat")
                         "")
                        recObj_akPn)
                       (pack "id"))
                  <*>
                    ((((Data.Aeson.TH.lookupField parseJSON)
                         "Telegram.Bot.API.Types.Chat")
                        "")
                       recObj_akPn)
                      (pack "type"))
                 <*>
                   ((((Data.Aeson.TH.lookupField parseJSON)
                        "Telegram.Bot.API.Types.Chat")
                       "")
                      recObj_akPn)
                     (pack "title"))
                <*>
                  ((((Data.Aeson.TH.lookupField parseJSON)
                       "Telegram.Bot.API.Types.Chat")
                      "")
                     recObj_akPn)
                    (pack "username"))
               <*>
                 ((((Data.Aeson.TH.lookupField parseJSON)
                      "Telegram.Bot.API.Types.Chat")
                     "")
                    recObj_akPn)
                   (pack "first_name"))
              <*>
                ((((Data.Aeson.TH.lookupField parseJSON)
                     "Telegram.Bot.API.Types.Chat")
                    "")
                   recObj_akPn)
                  (pack "last_name"))
             <*>
               ((((Data.Aeson.TH.lookupField parseJSON)
                    "Telegram.Bot.API.Types.Chat")
                   "")
                  recObj_akPn)
                 (pack "all_members_are_administrators"))
            <*>
              ((((Data.Aeson.TH.lookupField parseJSON)
                   "Telegram.Bot.API.Types.Chat")
                  "")
                 recObj_akPn)
                (pack "photo"))’
    |
436 | deriveJSON' ''Chat
    | ^^^^^^^^^^^^^^^^^^

Error using botJob with cron < 0.7

Please, specify cron version as >= 0.7.0 in package.yaml as dependencies, because botJob is unusable otherwise - MichaelXavier/cron#41 . Previous version of cron try to parse incorrect time, for example "2020-11-12 13:60" with error and bot stop working.

Missing Updating Messages: Bot API 5.5

editMessageCaption: https://core.telegram.org/bots/api#editmessagecaption
editMessageMedia: https://core.telegram.org/bots/api#editmessagemedia
editMessageReplyMarkup: https://core.telegram.org/bots/api#editmessagereplymarkup
stopPoll: https://core.telegram.org/bots/api#stoppoll
deleteMessage: https://core.telegram.org/bots/api#deletemessage

High CPU usage

Even running TODO Bot from example takes up up to 10% of my CPU on idle when no messages are sent on any of the chat the bot is on. It's in my opinion unacceptable.

Testing helpers

There should be an easy way to write tests for Telegram bots.

Perhaps we should see what they do in Python: https://github.com/python-telegram-bot/python-telegram-bot/wiki/Writing-Tests

Games: Bot API 5.5

https://core.telegram.org/bots/api#games

Types

Game: https://core.telegram.org/bots/api#game
CallbackGame: https://core.telegram.org/bots/api#callbackgame
GameHighScore: https://core.telegram.org/bots/api#gamehighscore

Methods

sendGame: https://core.telegram.org/bots/api#sendgame
setGameScore: https://core.telegram.org/bots/api#setgamescore
getGameHighScores: https://core.telegram.org/bots/api#getgamehighscores

Example

Simple game example.

Inconsistency in parseMode fields

Some objects are using PareseMode type (SendMessageRequest, SendDocumentRequest, SendPhotoRequest, etc) for theirs parseMode field, and some others just Text (SendAudioRequest, SendVideoRequest, etc).

This PR #114 should fix it.

Oudated Types: Bot API 5.5

Can't respond to inline buttons actions

ChatID is empty on messages from inline buttons

Error while parsing Int32

I use version 0.3.4.
I've got this in my bot:
DecodeFailure "Error in $.result[0].message.from.id: parsing Int32 failed, value is eithe
r floating or will cause over or underflow 5.067420826e9" (Response {responseStatusCode = Status {statusCode = 200, statusMessage = "OK"}, response
Headers = fromList [("Server","nginx/1.18.0"),("Date","Mon, 20 Dec 2021 13:21:11 GMT"),("Content-Type","application/json"),("Content-Length","399")
,("Connection","keep-alive"),("Strict-Transport-Security","max-age=31536000; includeSubDomains; preload"),("Access-Control-Allow-Origin","*"),("Acc
ess-Control-Allow-Methods","GET, POST, OPTIONS"),("Access-Control-Expose-Headers","Content-Length,Content-Type,Date,Server,Connection")], responseH
ttpVersion = HTTP/1.1, responseBody = "{"ok":true,"result":[{"update_id":68483329,\n"message":{"message_id":27943,"from":{"id":5067420826,

Looks like last number in fragment parsed incorrectly.

From telegram bot api:
Unique identifier for this user or bot. This number may have more than 32 significant bits and some programming languages may have difficulty/silent defects in interpreting it. But it has at most 52 significant bits, so a 64-bit integer or double-precision float type are safe for storing this identifier.

I have read changes up to 0.3.8 and find no fix for this.

Error `Couldn't match type ‘ClientEnv’ with ‘Maybe a0 -> ClientEnv’`

I get the following error when building as a dependency for my project:

[ 6 of 13] Compiling Telegram.Bot.API.MakingRequests ( src/Telegram/Bot/API/MakingRequests.hs, .stack-work/dist/x86_64-linux-nopie/Cabal-1.24.2.0/build/Telegram/Bot/API/MakingRequests.o )
    
    /home/legopelle/owncloud/programming/haskell/telegram-bot-simple/src/Telegram/Bot/API/MakingRequests.hs:24:34: error:
        • Couldn't match type ‘ClientEnv’ with ‘Maybe a0 -> ClientEnv’
          Expected type: IO (Maybe a0 -> ClientEnv)
            Actual type: IO ClientEnv
        • In the first argument of ‘(<*>)’, namely
            ‘ClientEnv <$> newManager tlsManagerSettings
             <*> pure (botBaseUrl token)’
          In the expression:
            ClientEnv <$> newManager tlsManagerSettings
            <*> pure (botBaseUrl token)
            <*> pure Nothing
          In an equation for ‘defaultTelegramClientEnv’:
              defaultTelegramClientEnv token
                = ClientEnv <$> newManager tlsManagerSettings
                  <*> pure (botBaseUrl token)
                  <*> pure Nothing

Any ideas why?

DecodeFailure on copyMessage

copyMessage expects MessageId as a result, but receives an object {"message_id": x},
so it fails with DecodeFailure "Error in $.result: parsing Integer failed, expected Number, but encountered Object"

This PR #116 should fix it.

New PhoneNumber MessageEntity type

Telegram API now has a new MessageEntity - https://core.telegram.org/tdlib/docs/classtd_1_1td__api_1_1text_entity_type_phone_number.html

Last time we has the same problem with Cashtag MessageEntity. I think we need some common fix for the problem. It is not good to change type for every change of Telegram API. But for now I just extended the type (wait for my PR please).

Outdated Methods: Bot API 5.5

sendMessage:
- request: + entities, allow_sending_without_reply.
deleteMessage:
- ~~move from MakingRequests to UpdatingMessages module.~~
sendDocument
- request: + caption_entities, disable_content_type_detection, allow_sending_without_reply.
sendPhoto
- request: + caption_entities, allow_sending_without_reply.

Missing Methods: Bot API 5.5

Missing Types: Bot API 5.5

Telegram Passport: Bot API 5.5

https://core.telegram.org/bots/api#telegram-passport

Types

PassportData: https://core.telegram.org/bots/api#passportdata
PassportFile: https://core.telegram.org/bots/api#passportfile
EncryptedPassportElement: https://core.telegram.org/bots/api#encryptedpassportelement
EncryptedCredentials: https://core.telegram.org/bots/api#encryptedcredentials
PassportElementError: https://core.telegram.org/bots/api#passportelementerror

Methods

setPassportDataErrors: https://core.telegram.org/bots/api#setpassportdataerrors

Inline Mode: Bot API 5.5

https://core.telegram.org/bots/api#inline-mode

Types

InlineQuery:
- + chat_type.
InlineQueryResult: https://core.telegram.org/bots/api#inlinequeryresult
InputMessageContent: https://core.telegram.org/bots/api#inputmessagecontent
ChosenInlineContent: https://core.telegram.org/bots/api#choseninlineresult

Methods

answerInlineQuery:
- request: + cache_time, is_personal , next_offset , switch_pm_text , switch_pm_parameter .

Upload haddock to hackage

See here for how to upload the haddock, plus some troubleshooting steps if it doesn't work automatically.

I believe all you need to do is stack haddock && stack upload.

Note for anyone else looking for the docs: you can build the docs locally, just do stack haddock and it will put the docs in somewhere like /.stack-work/install/x86_64-linux-nix/lts-11.15/8.2.2/doc/telegram-bot-simple-0.2.0/index.html

Bot API 6.6

See https://core.telegram.org/bots/api for changelog

Given the amount of new stickers method it is reasonable to split the module onto multiple sub-modules and then re-import them in Telegram.Bot.API.Stickers.

`Telegram.Bot.API.UpdatingMessages.editMessageReplyMarkup` is seemingly broken

When trying to use editMessageReplyMarkup, I get the following error:

Left (DecodeFailure "Error in $.result: expected an object with a single property where the property key should be either \"Left\" or \"Right\"" (Response {responseStatusCode = Status {statusCode = 200, statusMessage = "OK"}, responseHeaders = fromList [("Server","nginx/1.18.0"),("Date","Thu, 22 Dec 2022 19:59:59 GMT"),("Content-Type","application/json"),("Content-Length","779"),("Connection","keep-alive"),("Strict-Transport-Security","max-age=31536000; includeSubDomains; preload"),("Access-Control-Allow-Origin","*"),("Access-Control-Allow-Methods","GET, POST, OPTIONS"),("Access-Control-Expose-Headers","Content-Length,Content-Type,Date,Server,Connection")], responseHttpVersion = HTTP/1.1, responseBody = "{\"ok\":true,\"result\":{\"message_id\":<snip>}}"}))

(The gist is that aeson tries to parse result as a sum type data Either a b = Left a | Right b, which the value does not satisfy)

I haven't tested other edit* functions.

I'm using telegram-bot-simple-0.4.5, and aeson-2.0.3.0

Outdated Updating Messages: Bot API 5.5

editMessageText:
- request: + entitites.

Why BotM has to end with an action?

It looks like ending BotM with pure NoAction is boilerplate. As well as handleAction NoAction = pure model.

So, an extra action is always issued.

And user Action is always ~ Maybe Action'.

At the same time, botAction allows for the absence of action with Maybe in its signature.

Is Eff really needed? How to send a message without an extra action?

Problems with demo-bot.exe

So i finally solved all the problems with libraries, but when I'm trying to run exe file to put in Telegram.Token, it's just don't want to work

Stickers: Bot API 5.5

https://core.telegram.org/bots/api#stickers

Types

Sticker (move from Types): https://core.telegram.org/bots/api#sticker
StickerSet: https://core.telegram.org/bots/api#stickerset
MaskPosition: https://core.telegram.org/bots/api#maskposition

Methods

sendSticker: https://core.telegram.org/bots/api#sendsticker
getStickerSet: https://core.telegram.org/bots/api#getstickerset
uploadStickerFile: https://core.telegram.org/bots/api#uploadstickerfile
createNewStickerSet: https://core.telegram.org/bots/api#createnewstickerset
addStickerToSet: https://core.telegram.org/bots/api#addstickertoset
setStickerPositionInSet: https://core.telegram.org/bots/api#setstickerpositioninset
deleteStickerFromSet: https://core.telegram.org/bots/api#deletestickerfromset
setStickerSetThumb: https://core.telegram.org/bots/api#setstickersetthumb

Example

~~send some sticker to user via bot when user's message in chat with bot contains some keyword.~~ send sticker back to user if message is a sticker of course.

Async function starts bot in sync mode

startBotAsync_ starts bot in sync mode

Can I forward messages?

I wasn't able to find that in source code

Errors from the actions are consumed without any messages

Currently all the errors from the telegram server (ones that runClietM is returned with) are consumed without any trace. It's very inconvenient to debug the bot in this setting. For the local debugging I've added:

 processActionsIndefinitely botApp botEnv = forkIO . forever $ do
-  runClientM (processActionJob botApp botEnv) (botClientEnv botEnv)
+  runClientM (processActionJob botApp botEnv) (botClientEnv botEnv) >>= \case
+     Right x -> pure ()
+     Left e -> print e

That at least logs the results so it's possible to see what has gone wrong. But ideally there should be some better solution, like installing own exception handler. Also it would be nice to be able to catch such exceptions from the actions, for example if bot resends a message that could fail due to the bad markup and we want to send an totally escaped message in case of a error, or implement clever retry.

I can contribute an implementation if we agree on the design.

Bot API 5.6

Source: https://core.telegram.org/bots/api#december-30-2021

What is callbackQueryDataRead?

This function has type callbackQueryDataRead :: Read a => UpdateParser a ,is not documented, and used in todolist example, please add docs or comments

Delays in update handlers

Hi, I need to delay for a few seconds before replying to some certain messages, but do not need these replies to be ordered, that is, these replies should be "streamlined".

Q1 (delay for 1 sec)
Q2 (immediately follows Q1)
A1 (received after 1sec)
A2 (immediately follows A1)

I observed that the updates are received 'concurrently', but the actions are not: A2 appears after 2 secs.

It seems there is no easy support for this scenario currently, and I may need to use bot jobs. I looked into Internal.hs and it seems the actions are serialized by botActionsQueue. (If I understand it correctly.)

Is there a better way to do it with the current version of the library?

Implement document upload

For that we need to implement multipart/form-data support.
There is no general support for that in servant, so I think we should wait for fizruk/http-api-data#24.

Until then we can just copy over some code from somewhere.

Inline mode support

Can I program an inline mode bot using this library?

Wrong type in EditMessageTextRequest record

The EditMessageTextRequest type contains a field editMessageTextRequestInlineMessageId which has type MessageId and is represented as Int.
Official Telegram Bot API documentation describes this parameter as a String.

It would be the right choice to make the `inlineMessageId` field of `EditMessageRequest` represented by `Text` instead of an `Int`

Bot stops responding after some period

Bot stops responding after ~ 1 day. Only application restart helps.
Let me know if I can help you with debugging this issue.

Building library fails in Windows

Conversation bot improvements

currentChatId always returns Maybe ChatId but in conversationBot we always have ChatId. It leads to meaningless boilerplate code every time ChatId is needed in handlers.
What do you think about ConversationM?
Here is example:

newtype ConversationM a =
  ConversationM { _runConversationM :: ReaderT (ChatId, Update) ClientM a }

@fizruk
Is there are any hidden issues which will block this improvement?
If you are OK with this I will try to create prototype next week.

Add support for bot mention in command

Currently commands with bot mentions are not supported, eg: /help@my_awesome_bot

Build failure with servant 0.16

[ 8 of 21] Compiling Telegram.Bot.API.MakingRequests ( src/Telegram/Bot/API/MakingRequests.hs, dist/build/Telegram/Bot/API/MakingRequests.o )

src/Telegram/Bot/API/MakingRequests.hs:31:51: error:
    Not in scope: type constructor or class ‘ServantError’
   |
31 | defaultRunBot :: Token -> ClientM a -> IO (Either ServantError a)
   |

Bot API 5.7

Source: https://core.telegram.org/bots/api#january-31-2022

Bot name is very incovinient to access from UpdateParser

I found today it's really hard to parse commands in UpdateParser, becaus I need to parse the @my_bot_name part, but I don't have access to the name.

As far as I understand, I can get bot's User from BotM via reader botContextUser, or from BotEnv which is internal.

I can't use BotM's reader because that is created after botAction is created.

I can sort of use BotEnv, but it comes with two big downsides: I need to replicate startBot_ myself, and I need to use recursive do because, again, botAction must be created before I run startBotEnv

sendDocument API is missing

There is an API for sending documents by the bot https://core.telegram.org/bots/api#senddocument

But it's missing form the library. Would be nice to have it.

`command` UpdateParser is eating newlines

Currently command UpdateParser looks like lthis:

command :: Text -> UpdateParser Text
command name = do
  t <- text
  case Text.words t of
    (w:ws) | w == "/" <> name
      -> pure (Text.unwords ws)
    _ -> fail "not that command"

And because of words -> unwords all newlines of the message text vanish.

If this is an intended behavior, then ok.

For myself I'm using my version of command:

command :: Text -> UpdateParser Text
command name = do
    t <- text
    let (cmd, rest) = Text.break isSpace t
    if cmd == "/" <> name
        then pure $ stripStart rest
        else fail "not that command"

I can make a PR with this version, if loosing newlines was not intended and my version is fine codewise.

fizruk / telegram-bot-simple Goto Github PK

telegram-bot-simple's People

Contributors

Stargazers

Watchers

Forkers

telegram-bot-simple's Issues

Types

Methods

Types

Methods

Example

Types

Methods

Types

Methods

Bot API 6.6

Types

Methods

Example

It would be the right choice to make the inlineMessageId field of EditMessageRequest represented by Text instead of an Int

Recommend Projects

Recommend Topics

Recommend Org

It would be the right choice to make the `inlineMessageId` field of `EditMessageRequest` represented by `Text` instead of an `Int`