flaming-codes / crane-app Goto Github PK

Implementation PR

No response

Reference Issues

No response

Summary

The current implementation uses the ServiceWorker to host our Typeahead database. This was implemented due the following reasons:

• instance off the main thread, as ServiceWorker has its own process
• SW proxies as requests to the typeahead-URL, which makes the implementation in FE very nice, as the client only calls the endpoint
• gets updated w/ new SW-updates

Although its working nicely, the setup can be improved by using a WebWorker as host for the DB:

• better separation of concerns, as SW will be reduced to its work as network proxy
• clearer implementation for new devs, as the DB doesn't get hidden away in SW
• less time for SW in install-phase

Basic Example

1. PWA gets requested by client
2. The search-component spawns + sends an init-event to the DB-WebWorker
3. DB either initialises from scratch (first call) or checks if the cache timestamp is outdated and initialises if so
4. if init: load latest items, store them via IDB, populate Loki, send init/201 event

At this point, the worker is ready to accept queries for Typeahead-suggestions.

Drawbacks

We'll use commlink as helper lib. Thankfully, its size-footprint is very small, yet it introduces great DX-enhancements for WebWorker communication.

Unresolved questions

No response

Describe the bug
While on a package detail page, the shortcut for copying the install command (ctrl + shift + C) does not work.

To Reproduce

1. Go to a package detail page
2. Press ctrl + shift + C
3. Notice no popup and command is not in clipboard

Expected behavior
Command should have been added to clipboard with a popup notifying of the copying

Desktop (please complete the following information):

• OS: Win 11
• Browser: Chrome, Edge

Description

For any package listed on on the website, if I click on the github-link it will open a new window to the repository, but at the same time it redirects the original site to the same link.

Reproduction steps

1. Go to https://www.cran-e.com/package/tidyverse
2. Scroll down to `About`
3. Click on the github-link

Browsers

Firefox

OS

Windows