flowcrypt / flowcrypt-ios Goto Github PK

• log in -> cancel
• log in -> approve -> bad pass phrase
• log in -> approve -> no backups -> switch email
• log in -> approve -> no backups -> generate pubkey -> weak pass phrase
• log in -> approve -> no backups -> generate pubkey -> good pass phrase -> wrong repeat
• log in -> approve -> no backups -> generate pubkey -> good pass phrase -> correct repeat -> create key
• log in -> approve -> no backups -> generate pubkey -> switch accounts
• log in -> approve -> loaded 1 backup -> good pass phrase -> inbox
• restart app -> loads inbox
• send new msg -> inbox -> switch to sent -> open sent msg and verify content, recipient, subject
• send new msg -> no pubkey
• move msg to archive -> verify in archive
• move msg to Trash -> verify in trash -> verify no bin button on moved msg
• inbox -> open first msg -> to trash -> inbox -> open following first msg (to prevent crash as in #119)

can use Gmail IMAP search extension on Gmail accounts, so that users can continue using gmail search tricks

@RomanKovalchuk2019

After #32 landed, the "trash" icon will no longer move mail to trash folder. Maybe it does something? But I'm not sure what.

When I click it on a particular message, I expect it will say "Moved to trash" and show inbox, without that message. Instead, it stays in message view. If I click trash again, nothing happens again. I can go back to inbox, refresh it and still see the message. Then I can open it again, click trash again, and nothing happens.

If I kill the app and retry, the trash icon on that message still does nothing.

This used to work.

currently can only see the very last few messages

depending if the contents were encrypted or not

If the date is today, show time
if the date is not today, show date
Applies both to inbox view and Msg view
Check out how the Android app does it

eg when opening a message

currently it just alerts

there should be a common handling mechanism for these errors, probably a retry/cancel button

Today, when there is no backup, the iOS app will show a Retry or Change Account button.

See what the Android app does when there is no backup found - it will give options to create a new key or import key manually.

Please do the same, but Create new key should show a toast it's not implemented once clicked.

Then Import Private Key should show options similar to what Android does, and allow the user to set up the account that way.

where appropriate

Core folder should only contain classes directly related to the TypeScript core

do not use force unwraping(let userInfo: NSDictionary = notification.userInfo! as NSDictionary) and so on

I use an iPod touch as my debugging device.

Sometimes I have to tap an icon 2 or 3 times before it registers the tap (often I notice this when trying to open the side menu).

My guess is that maybe the tappable icon area is too small, maybe something like this:

It would be better to increase it to take up as much space around the icon as possible, for all icons, maybe like this:

On the splash screen

Privacy -> https://flowcrypt.com/privacy
License -> https://flowcrypt.com/license
Security -> https://flowcrypt.com/docs/technical/security.html

seems to be taking very long, like 30-45 seconds

Correctly it should be showing like this, and it does when I click on folder to select it manually in the menu:

But when I open the menu right after app start, the folder is not highlighted:

shoudl show more appropriate err msg

add libs as pods not as source files. Easier to maintain, improve compile time

When I keep scrolling down, I want to see more messages until there are no more to show

There are lot of broken layouts around the app, especially when viewed on different size devices.

No thought was given to responsive design so far, and this needs to be fixed.

Here's an example of a broken layout, but there are many, and many of them are subtle.

As a part of this issue:

• fix any obvious brokenness like the one on the screenshots below
• fix any more subtle broken ui, and document what was fixed
• establish common padding and margins around text and buttons, and consistently apply it throughout the app
• document here your choices for common element padding sizes, distance between buttons, line item sizes, text sizes, etc
• test and fix design for devices starting with iPod touch all the way up to iPhone X
• test the app on at least one iPad and fix any obviously broken parts
• test the app in landscape iPhone view and fix where necessary
• provide screenshots of what was fixed and how the result looks
• fix or propose ui / design improvements
• fix xcode layout warnings
• when all done, please provide a screenshots of what the app looks on several screens on small iPhone, large iPhone and any tablet.

My biggest worry is that if we do all UI in code, there will be too much code, or code readability will suffer by mixing UI and logic.

Hopefully you can find a way to minimize that.

4 issues to fix:

• darken or blur tappable area (to the right side of the menu) that can hide the menu
• fix hiding side menu when in landscape mode (currently tapping outside does not hide menu)
• fix menu layout when I open menu in landscape mode, then switch to portrait mode while menu is still open (screenshots below)
• make sure closing tappable area self-adjusts when I switch from landscape to portrait and back

open menu in landscape mode, then switch to portrait:

Can even still tap one of the inbox items.. (bug):

there are few places where you have retain cycle.
Your viewcontrollers would never dealocated

the latest one uses isFullyDecrypted / isFullyEncrypted instead of isDecrypted.

after #57 lands

• Inbox should be always ordered as first
• it should be showing as Inbox, not INBOX, regardless of actual folder name
• All Mail should always be second, when present

Eg here example of what we don't want:

1. make a video
2. wait for #38 (#57) to land
3. release a new version to TestFlight
4. submit to Apple for TestFlight review
5. wait for Apple to review it
6. submit to Google for verification
7. wait for response from Google
8. respond to google with clarification
9. submit to apple for final review
10. let google know when reviewed by apple
11. ???
12. done

follow up from #25 currently only sha256

https://tools.ietf.org/html/rfc4880#section-9.4

      ID           Algorithm                             Text Name
      --           ---------                             ---------
      1          - MD5 [HAC]                             "MD5"
      2          - SHA-1 [FIPS180]                       "SHA1"
      3          - RIPE-MD/160 [HAC]                     "RIPEMD160"
      8          - SHA256 [FIPS180]                      "SHA256"
      9          - SHA384 [FIPS180]                      "SHA384"
      10         - SHA512 [FIPS180]                      "SHA512"
      11         - SHA224 [FIPS180]                      "SHA224"

• fix menu closing bug

Eg when I know I'm expecting a message, I intuitively keep pulling down

fix icon spacing in compose - should lean towards the right side, with equal spacing between them, leaving enough space for the title (eg Compose)

Hide trash icon when the message is already in Trash, relevant code (to fix):

        if self.path == "[Gmail]/Trash" {
            // self.btnTrash.isHidden = true; // todo - hide the trash btn
        }

and to remove:

        guard self.path != "[Gmail]/Trash" else { // todo - does not need to be here once trash btn is hidden
            self.showToast("Message is already in trash")
            return
        }

Ensure spacing of other icons does not break without the trash icon.

to reproduce:

1. delete app -> install -> log in -> recover by adding pass phrase -> inbox shows
2. click side menu - nothing happens (bug)
3. restart app - > click side menu - menu opens

1. open unread message
2. hit the back button
3. message still looks unread
4. refresh inbox by pulling down -> now correctly read

The message should be visible as read right away when hitting back button, similar how archive button will show visible result right away.

• Remove msg placeholder when focused
• make typed text show in black
• use standard size for composed text: 17
• make compose field scrollable (currently cannot see text if I write too many lines)

May I contribute to this project?

It should say
Attachments not implemented yet

Right now it only searches in inbox.

If user archived the backup email, the app won't find it, which is a bug.