Comments (9)
What do you think if we have an option for always enabled and a blacklist or always disabled and a whitelist? So having both.
from fin-spell.
Yeah, that sounds very good!
from fin-spell.
Okay, I did this. Now you need to refresh the page if you change the setting. Is it a problem? It can't be changed with the current implementation. I used contentScripts API, it made things easy.
from fin-spell.
Were you able to run the add-on in the development environment? I could push the commits and you could test them there.
I pushed enabled-disabled branch for testing.
from fin-spell.
Yes, I was able to run and build the extension by using the sources I grabbed from here (git, enabled-disabled branch).
Now you need to refresh the page if you change the setting. Is it a problem?
To be honest, I think this is a problem because if I want to turn the spell checking on/off temporarily from the flag icon it does not turn on/off it immediately: so the worst scenario is that I have to refresh the page and I will lose all the text I've written...
Maybe I revert what I said earlier: Is it possible to use the Always Disabled / Always Enabled feature as the permanent setting and in addition to that there is possiblity to turn off/on the spell checking temporarily from the flag icon (and maybe from the context menu in the future #8) and it disables/enables the spell checking immediately for the active tab only?
from fin-spell.
Maybe I revert what I said earlier: Is it possible to use the Always Disabled / Always Enabled feature as the permanent setting and in addition to that there is possiblity to turn off/on the spell checking temporarily from the flag icon (and maybe from the context menu in the future #8) and it disables/enables the spell checking immediately for the active tab only?
Yes, I can do that, I think.
from fin-spell.
In the latest commit in the development branch, the functionality is now that the options control spell checking globally and you can temporarily enable or disable spell checking in the active tab. Refreshing the tab restores the global setting. Does it now work as you would like?
from fin-spell.
Yes, now it feels very good! Thanks.
from fin-spell.
I think this issue / feature request can be closed if you want to? I can confirm that this functionality is added and tested, thanks!
from fin-spell.
Related Issues (11)
- User set highlighting isn't used in sidebar
- div role="textbox" elements are not spell checked HOT 5
- Start using manifest v3 API
- Set spellcheck to false in the edited element HOT 1
- Don't highlight the whole text on every key press HOT 5
- emsdk version in readme isn't found anymore as a precompiled package HOT 1
- Enlarge the textarea to always fill the sidebar HOT 2
- Read the word under mouse pointer when opening context menu without left mouse click
- Add Päälle/Pois functionality in Firefox context menu HOT 12
- Do not spell check the word which is still under typing HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fin-spell.