Add Päälle/Pois functionality in Firefox context menu about fin-spell HOT 12 CLOSED

Should the context menu switch apply only on the current tab or be a global switch?

from fin-spell.

Hmm, good question. Personally I would prefer to set it on globally as long as the user switch it back to off.

And I think this could be partly linked to my another feature request: #7 If that persistent setting is set to ON then this should set the ON/OFF globally as well.

from fin-spell.

So, the action bar (toolbar) and the context menu switches would do the same action, globally switch between always disabled or enabled? I'll try to implement this then.

from fin-spell.

Yeah, exactly.

from fin-spell.

I added the context menu item in the enabled-disabled branch if you want to test it.

from fin-spell.

Yeah, I tested this and it works, thanks!

BTW: Just a minor UIX thing: Is it possible to implement the context menu entry without a submenu? Maybe it can achieved by using menu entry with content: "Fin Spell: Set semporarily On" / "Fin Spell: Set semporarily Off" (depending what setting is currently set) directly on the root context menu:

from fin-spell.

And another thing: If toggle the spelling temporarily off (either from the context menu or by clicking the Finnish flag icon) it removes all the highlightings immediately but if I turn it back on it does not trigger the spell checking immediately: I have to change the text (put one space for example at the end) and after that it highlights the mispelled words.

Is it possible to trigger the spell checking for the whole text immediately the spell checking is turned on (temporarily)?

from fin-spell.

Yeah, I tested this and it works, thanks!

BTW: Just a minor UIX thing: Is it possible to implement the context menu entry without a submenu? Maybe it can achieved by using menu entry with content: "Fin Spell: Set semporarily On" / "Fin Spell: Set semporarily Off" (depending what setting is currently set) directly on the root context menu:

It's possible.

from fin-spell.

And another thing: If toggle the spelling temporarily off (either from the context menu or by clicking the Finnish flag icon) it removes all the highlightings immediately but if I turn it back on it does not trigger the spell checking immediately: I have to change the text (put one space for example at the end) and after that it highlights the mispelled words.

Is it possible to trigger the spell checking for the whole text immediately the spell checking is turned on (temporarily)?

And this is possible too. Probably a simple call to highlight all the inputs.

from fin-spell.

And another thing: If toggle the spelling temporarily off (either from the context menu or by clicking the Finnish flag icon) it removes all the highlightings immediately but if I turn it back on it does not trigger the spell checking immediately: I have to change the text (put one space for example at the end) and after that it highlights the mispelled words.
Is it possible to trigger the spell checking for the whole text immediately the spell checking is turned on (temporarily)?

And this is possible too. Probably a simple call to highlight all the inputs.

Added in the newest commit. All the input elements are spell checked on page load and if you temporarily enable spell checking. The last input element has the focus, this probably needs fixing. And the last word in input elements are not spell checked. I guess when the element gets focused and the cursor is placed in the end and the last word is considered as the current word you are typing.

from fin-spell.

Now in the latest commit, on off context menu item should be shown without a sub-menu when possible.

from fin-spell.

Yes, thanks! It's perfect!

I think this issue / feature request can be closed if you want to? I can confirm that this functionality is added and tested, thanks!

from fin-spell.