Comments (6)
zanderso
commented on July 22, 2024
7
CP not lgtm. The patch is quite large, the fix exists in multiple beta versions, and there is a workaround. We should not be cherry-picking this to stable so late in the cycle.
from flutter.
harryterkelsen
commented on July 22, 2024
5
Should be OK to cherry-pick this. LGTM
from flutter.
itsjustkevin
commented on July 22, 2024
@ditman can you take a look at this cherry-pick request?
from flutter.
ditman
commented on July 22, 2024
@itsjustkevin just pinged the team, this is probably a fine CP, but I'm not a super expert on this /cc @yjbanov @harryterkelsen in case this needs to CP more!
from flutter.
godofredoc
commented on July 22, 2024
@harryterkelsen https://github.com/flutter/engine/pull/51730/checks?check_run_id=23353796553 is failing engine unit tests , is there an additional change that needs to be CP'ed?
from flutter.
dickermoshe
commented on July 22, 2024
Ouch
https://examples.flame-engine.org/#/Collision_Detection_Multiple_shapes
from flutter.
Related Issues (20)
- Support reverseCurve in expansionAnimationStyle of ExpansionTile HOT 1
- ThemeData Color rendering discrepancy HOT 5
- [integration_test] Test runner reports "All tests passed" when test setup fails HOT 7
- DropdownMenu throws exception when nested inside two SingleChildScrollView HOT 5
- [tool_crash] FileSystemException: Creation failed, OS Error: No such file or directory, errno = 2 HOT 2
- mac-10 lost external connection phone device. HOT 2
- linux-38 lost external connection phone device. HOT 2
- mac-6 lost external connection phone device. HOT 2
- App is not working in Android version 14 HOT 1
- Greenhouse to Flight School device move staging and prod Phase 1 HOT 3
- [Camera][Android] Rendering is split in two HOT 3
- Overlay wrong position in ShellRoute HOT 2
- [web] a11y focus ring rect frequently broken for plain text HOT 2
- [A11y][Android] Badge bubble does not scale with text font size HOT 3
- mac-11 is dead. HOT 4
- mac-7, mac-9 and mac-24 are dead. HOT 3
- Rebasing in engine prints "gclient sync -D" reminder twice HOT 1
- i have an error when i run flutter doctor HOT 2
- [video_player] Video disappears on pause in safari HOT 5
- [CP] [canvaskit] Fall back to multi-context rendering on Firefox and Safari HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flutter.