fnoyanisi / zstring Goto Github PK

zstring_rtrim is documented as "Trims trailing white-space characters" but only removes space characters rather than anything that is true for isspace()

Add doxygen style comments for proper documentation

Hello,

If the replacement string size (y) is not equal to the needle size (x) zrepstr(...) function overwrites other characters.

For example,

#include <stdio.h>
#include <string.h>

#include "zrepstr.h"

int main()
{
    char str[50] = {0};

    snprintf(str, sizeof(str), "My simple text message");
    zrepstr(str, "text", "more than text");
    fprintf(stdout, "%s\n", str);
}

Where "more than text" overwrite the "message" string and it becomes something like this, "My simple more than te".

I guess in the trim functions, variable index should be of type ptrdiff_t and not int.

• Add a license file to the repo
• zstring_remove_chr.h seems to have Original BSD 4-Clause license wheras all others are Simplified BSD 2-Clause.

Thread-safe variants of both strtok implementations (that do not rely on static variables) are interesting. See strtok_r (on POSIX) or strtok_s (the Win-specific one with three arguments) for maintaining the context between successive calls.