Comments (7)
Yeah, your absolutely correct @derTobsch , my apologies
from jollyday.
Thanks for your issue @AndreasPetersen,
as described here https://en.wikipedia.org/wiki/Public_holidays_in_Denmark the 24.12. is not a official public holiday. Is that correct? Same here https://github.com/nager/Nager.Date/blob/main/src/Nager.Date/PublicHolidays/DenmarkProvider.cs.
from jollyday.
Isn't there still the following issues?
- names of the holidays on December 25 and 26 are incorrect. I would argue that the English Wikipedia also has the incorrect names. In Danish they are litterally called first and second christmas day (perhaps with the first it is often just called christmas day). I can see that there is a first and second Christmas day name
- General prayer day is no longer starting next year (should have a
validTo="2023"
added)
from jollyday.
If you want you can provide a pull request and improve the public holidays of Denmark. Of course you will get support from me.
from jollyday.
Hey @AndreasPetersen,
I removed the general payers day starting from 2024.
I have no idea how I will continue with the translations in this lib. It is possible to add a new holiday_descriptions_dk.properties
to provide all the translation needed. But on the other side, we need to add all translations for all public holidays provided by jollyday, even if this public holiday is not available in Denmark.
Maybe we should provide a global holiday_descriptions.properties
with the English names of the public holidays for all holidays and provide specific holiday_descriptions_dk.properties
that only overrides the public holidays in Denmark. What do you think?
from jollyday.
I extracted the naming issue into #201 so we can fix the general prayer day in this issue
from jollyday.
Hi @derTobsch ,
Thank you for the effort, and apologies I haven't replied. I think it makes sense to extract the naming to a separate issue as done. I think you suggestion makes sense.
from jollyday.
Related Issues (20)
- Improve holiday types with bank holidays HOT 9
- Γ land Islands Whit Sunday is missing
- Whit Sunday missing in Liechtenstein
- Rename 'Official Holiday' to 'Public Holiday'
- Wrong federal states for Easter Sunday in Germany (Hessen)
- Morocco Amazigh new year starting from 2024
- More reliable Versioning possible?
- Jqwik Usage Survey HOT 2
- Indigenous People's Day missing in the United States
- Bulgaria: Moving Conditions are missing
- Add Cyprus
- Add Armenia
- Add Georgia
- South Africa: 29 May - Public holiday (General Elections) missing HOT 2
- Thread safety, especially HolidayManager (?)
- Improve Canadian holidays
- Support additional holiday types
- Missing EPIPHANY and ST_JOHN for Romania HOT 1
- Greece - Labour Day on May thr 7th for 2024
- French Subdivision holidays missing descriptions HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jollyday.