Missing days for german federals about jollyday HOT 6 CLOSED

Hi @derTobsch,

sure, here you go:
https://github.com/terwarf/jollyday_demo_missing_holidys_de_bw

Thanks for looking into that issue.

from jollyday.

@derTobsch Thanks a lot for the clarification. Now I get the expected results. 👍

from jollyday.

@terwarf thanks for bringing this up! Hope you enjoy the lib.

from jollyday.

Hey @terwarf,

thanks for your issue. Did you write a example project? Can you upload it to GitHub and send me a link to it? That would be great.

from jollyday.

Hey @terwarf,

this is because the readme is terribly wrong, how to retrieve the public holidays. Thanks for pointing that out.

You need to declare a HolidayManager with the correct parameters and not providing the country as args parameter.

It should be like this e.g.

        HolidayManager holidayManager = HolidayManager.getInstance(ManagerParameters.create(GERMANY));
        Set<Holiday> days = holidayManager.getHolidays(
                LocalDate.of(2023,1,1),
                LocalDate.of(2023,12,30),
                "bw"
        );

otherwise the fallback is the us as country and therefore you cannot retrieve any German public holidays

from jollyday.

I improved the readme as a quick fix. I think I should add more examples so that it will be clearer how to use the api. Also add more Javadoc.

from jollyday.