foobacca / justliving Goto Github PK

In submit.php replace "descrition" with "description"

An image is uploaded, but all I'm getting is the alt, not the image.

What steps will reproduce the problem?
1. open admin interface
2. open a random listing
3. click "upload web image" (or print image, although that doesn't do much
anyway right now)

What is the expected output? What do you see instead?

New tab doesn't contain anything. Should contain a form to upload photos.

httpdocs/admin/map.php has it's own database connection and it not linked 
from the main admin page. Should we just get rid of it?

Need to set the domain properly in the search function. it's currently
http://www.

Can someone talk me through how to add new categories? This could go on the
Customization page of the wiki.

It might also be useful to tell me about phpMyAdmin (Or direct me to
somewhere I can look.)

The search mechanism is fucked. It doesn't work on either the Cambridge or
Bristol sites. I don't know what the issue is.

There appear to be two copied of email code which are very similar, and
should probably be merged into one file for clarity and ease of
maintenance. They are:

httpdocs/admin/funcs/big_email.php
httpdocs/admin/listings/email.php

They also have names hardcoded into the email. (One says Ben and the other
says Tom). Sorting out the email to lots of listings should probably
involve custom text - maybe some standard bits, but also some to be entered
in text boxes, with a default bit. Or we could have an
email_contents.php.sample file.

I have tried to add a second category for a number of listings on the
Bristol site. i've used the tick box on the RHS of the listing page in the
admin section. But it doesn't work. I click "update listing" and then I go
to the main site, and the listing is not there. It remains in the first
category, but doesn't get added to the second.

If we're going to implement images we need to change the permissions to 777

My machine needed a reboot before it displayed everything properly.
Presumably one of the packages installed on the first line needs this to
start working properly. Best to insert this in the instructions.

see summary.

- allow users to upload photos/ embed video on their page.

- introduce an editorial log to keep track of stuff.

- Other things are obvious: make the admin page "nicer". Etc etc.
Obviously there's no pressure to make this happen, but thought you
might be interested.

The word 'Cambridge' is hard coded in various places in the php files. This
should come from a config variable in the config.php file, or in other
cases be part of a longer phrase that would come from the config.php file.
For example the phrase "proper positive guide to Cambridge" is used, and
"Just Living - an ethical guide to Cambridge" in various places. Maybe
other cities would want to use a different phrase.

The files are:

httpdocs/about.php - the top part (About Just Living) could be done with
just a {$city} variable, but the history section is definitely Cambridge
specific. It could be included from a history.php.sample file, or maybe
from the database.

httpdocs/index.php - 

httpdocs/admin/funcs/big_email.php - also see issue #7

httpdocs/admin/map.php - 

httpdocs/admin/listings/email.php - also see issue #7

httpdocs/getinvolved.php

phpincs/funcs.php - in the default page title, the meta keywords and the
send_jl_mail function

Thinking about .css development. I'm guessing this is a thing that new
sites will be editing most heavily.

It would be helpful to have an explanation of where the different logos are
used. Maybe a readme file might be in order?? We'll need to match the
dimesnions of new image files to old ones. And it'd be good to know which
files make reference to which logos...

Please provide instructions for putting a password on the admin page.

In the admin pages the first link to "Just Living Admin" doesn't work. The
path doesn't include "justliving/"

It would be good to allow people to upload photos to go with the guide
entries. Moderated and with resizing ideally.

duckpants said: I can see it being useful in the current system to allow
someone to upload a photo as a suggestion for their page (for moderation),
maybe with some clever re-sizing, or warning them that it's big, or just
allowing it through and having an admin edit it down.

(split out from issue 10)

What steps will reproduce the problem?
1. open up a random listing. Look at the text at the bottom of the listing
that says "submitted on X | last edited on Y". It may look like a small
smudged grey line but no! It is a bunch of tiny text.


What is the expected output? What do you see instead?

* bigger please.

It would be helpful if every admin page.

this is in the admin section. i've already deleted one listing by
accident!! it's too near the update listing button.

I added an addition. Had a look and then pressed "delete". But it was still
there!

Bristol request: social media links; many projects these days have more
than just
a web link; twitter, bebo, myspace, facebook et. So additional URL
spaces for social media links would be good. Suggest a drop down
box from 1 to say 5 that allows additional URLs to be added.

This could be my ignorance, but... the path for funcs.php doesn't seem to
relate to the main apps path. If you look at my config.php file below I had
to include "/home/nick/" in the path to get it to work. Which isn't very
consistent with the other paths (like  for css). It would be good if the
only thing you had to edit was that main apps path...

Also, you can remove the TODO from config.php! You've done it!

<?php
# uncomment the next line if you want to make tracking down errors easier
#error_reporting(E_ALL | E_STRICT);

# TODO: add variables - database connection details, city ...

# EDITME: application path - MAKE SURE YOU END WITH A /
# this is the path relative to the domain name. If you are the main app - ie 
# the index page is at http://domain-name.org/index.php then this should be
#$app_path = '/';
# If the index page is at http://domain-name.org/justliving/index.php then use
#$app_path = '/justliving/';
$app_path = '/justliving/';

# css path
$css_path = '/';

# Various variables 
$city = 'Bristol';
$guide_name = 'Just Living';
$guide_subtitle = 'A proper positive guide to Bristol';
$default_page_title = "Just Living - A proper positive guide to Bristol";

# is wiki in use, and what is the url
$wiki_in_use = true;
$wiki_url = 'http://wiki.justliving.org.uk/';

# is stats package in use, and what is the url
$stats_in_use = true;
$stats_url = 'http://www.justliving.org.uk/admin/phpMyAdmin/';

# is database admin in use, and what is the url
$db_admin_in_use = true;
$db_admin_url = 'http://www.justliving.org.uk/admin/stats.php';

# set time zone - for full list see http://uk3.php.net/manual/en/timezones.php
$time_zone = "Europe/London";
date_default_timezone_set($time_zone);

# make this path point to your copy of the funcs.php file
$funcs_include_path = '/home/nick/justliving/phpincs/';
set_include_path(get_include_path() . PATH_SEPARATOR . $funcs_include_path);

@(include($funcs_include_path . "funcs.php")) OR
  die ("Could not find funcs.php. Make sure you have set the path of
funcs.php in config.php");

What steps will reproduce the problem?
1. look at a random listing e.g. http://justliving.org.uk/guide/view.php?id=120
2. see the text at the top of the addition form that says "Please note. You
are about to contact the Just Living team NOT the organisation listed above."
3. we could replace this text with e.g.

"Please note - this is the JustLiving directory website, not the website
for Cambridge Freecycle. If you use this form you will be contacting Just
Living, not Cambridge Freecycle. If you want to contact Cambridge
Freecycle, look at the contact details above."

we get a number of false submissions every year from people thinking
they're getting in touch with the organisation mentioned, mainly Freecycle.

The url justliving.org.uk is hardcoded (as a web url and as the domain for
email addresses) in the below files and should be changed to use a variable
from config.php - we should have variables for

* site url
* contact email address
* other email addresses
* wiki url (if used)
* phpmyadmin url (if used)
* stats package url (if used)

httpdocs/admin/funcs/bigemail.php - email addresses and site url
httpdocs/admin/index.php - link to wiki
httpdocs/admin/listings/email-listings.php - email address
httpdocs/admin/listings/send-dead.php - email address
httpdocs/admin/listings/email.php - email address and site url
httpdocs/stockists/index.php - has links to pages of the guide - should be
a sample file I think.
phpincs/funcs.php - site url, wiki url and email addresses

When we view an addition we are given the options to set the state to:

* unchecked
* rejected
* live


- we don't set additions live any more, we just update the original
listing. Also, we can just delete nonsense additions, we don't need to
reject them. So, I think we actually want to the options to be something like:

* unchecked
* dealt with

- with "dealt with" meaning "I want to save this for posterity", and
anything else just deleted.

What steps will reproduce the problem?
1. go to admin/listings/

What is the expected output? What do you see instead?

Lots of php errors - will need to be worked through.

It's not necessary to do this:

$ cp httpdocs/css/website.css.sample httpdocs/css/website.css
$ cp httpdocs/stockists/index.php.sample httpdocs/stockists/index.php

We should just have these files in their standard format (just as we do for
the resources, about, principles page etc etc.

The above files should be edited when it comes to customising the site (see
the newly written instructions), not when setting it up initially. I'll try
and do this change - changing file names, editing instructions - soon.

This sounds obvious, but it is not apparent that you need to click on a
listing, e.g. bristol.indymedia.org/justliving/guide/… to find out more.
Could it not just have text at the bottom of the box for each listing
saying ‘click here for full listing’.

Bristol request: thumbnails appear on the list view. So, under, say
"housing", each entry has a small piccie on the right hand side.

The bristol crew found that in httpdocs/news.php they had to change a line:

//modified crash 20090609
//if ($id)
if (!$id = $_GET[id])

So we should check what versions of PHP/MySQL this applies to and commit it
in a portable way

Bristol request:  I think the submitting user should be able to add
a 2nd category too and other users add more...

prob just after the "Main Site" link

on view.php

same goes for the website.

Is currently hard coded as...
<input type="hidden" name="sitesearch" value="http://www.justliving.org.uk" />

So won't work on other installs.

The paypal button details are hardcoded at the bottom of each page in
phpincs/funcs.php It should be be put in the config file (probably along
with something to turn it on or off).

- I had to change !$subject in view.php to 1 in order for the addition to
be added to the database. I don't know why $subject is being set to TRUE.
am trying to debug.
- Furthermore, even with the edit above, no email was sent.

Got a 'phpinc.php' file in the httpdocs folder, so that all other files can
link to this (fixed position) which in turn links to the main 'funcs.php'
file (which should be located outside of the apache root, so anywhere on
the server.

Need to go through all the pages so they use this 'phpinc.php' instead of
linking the 'funcs.php' direct, to make install on other servers much easier.

Need to have this line in:

cp other/dbcreate-sample.sql other/dbcreate.sql

Bristol request: that there be images next to categories listing on front
page, and at top of each page. currently the site is very image-lite. we
may want to keep it that way though...

This category still refers to Cambridge.

just a reminder.

The listings are often interspersed with blank boxes. I'm wondering if
paragraph closing tags have not been used? Or something?

Might be nice to have an additional field for listings for 'print version
of organisation description'. Basically you might want lots of information
for the webite listings, but a cut down version for print to save on space.

If it's not completed, then you would use the 'long description' for the
print output. 

You could even be clever and include something like 'more infomation on the
website' with those listings in the printed publication.

I've installed the system following the ubuntu install instructions. I can
manipulate current listings, but it didn't accept a new listing that I
tried to put in.

Print some kind of big warning / kill the site if config.php isn't found
for some reason.

What steps will reproduce the problem?
1. enter a new listing with a phone number
2. save it
3. go back to it
4. click "send welcome email"
5. note the lack of a phone number in the email text

In submit.php put "Listing" not Listed".