SFDX is not properly ignoring non-salesforce workspaces about salesforcedx-vscode HOT 9 CLOSED

@paustint extensions should not activate if preconditions for activation are not met.

vscode-core precondition is "workspaceContains:sfdx-project.json" so not sure what is happening.
I tried this on a new folder whose contents are from a simple npm init and I am not seeing vscode-core mentioned in in ext host log.

I will see if I can find a reasonable explanation.

from salesforcedx-vscode.

@paustint I was unable to reproduce this in my environment. Could you check to see if any of the parent directories of you project has an sfdx-project.json file?

from salesforcedx-vscode.

I'll try to determine that when back at my computer. It only happened once and does not appear to continue to happen - so not exactly sure what happened. I will play around with restarting vscode and restarting extension host etc...

from salesforcedx-vscode.

@paustint thank you. I am going to close this issue. Please feel free to reopen it if you encounter the problem again.

from salesforcedx-vscode.

@peternhale - Is it normal that the extension shows an error message for all non-sfdx projects? This is really annoying to see this every time I start VSCode in non-sfdx workspaces.

These are the only things that show up in the output logs (this is from extension host output)

2024-02-27 07:22:08.596 [info] ExtensionService#_doActivateExtension salesforce.salesforce-vscode-slds, startup: false, activationEvent: 'onLanguage:javascript'
2024-02-27 07:22:08.638 [info] ExtensionService#_doActivateExtension salesforce.salesforcedx-vscode-core, startup: false, activationEvent: 'onView:sfdx.tasks.view'

from salesforcedx-vscode.

Here is the repo that I normally work in, but have seen the same happen on other computers with different codebases.
there is not an sfdx-project.json in the codebase, I am not using a multi-root workspace, and I have 100% confirmed that there is not an sfdx-project.json in any parent folders.

It is a very minor annoyance, so not something I am very concerned about.

from salesforcedx-vscode.

@paustint I just tried the jetstream project on my Mac with Salesforce Extension Pack v60.1.2 and I am not seeing either extension mentioned in the exthost log. I also tried with the expanded extension pack, with the same result.

Version: 1.86.2
Commit: 903b1e9d8990623e3d7da1df3d33db3e42d80eda
Date: 2024-02-13T19:42:13.651Z (2 wks ago)
Electron: 27.2.3
ElectronBuildId: 26908389
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: 11.8.172.18-electron.0
OS: Darwin x64 23.3.0

from salesforcedx-vscode.

@peternhale - I don't know if this helps at all, but I just noticed that this entry is showing up in the "Extension Hosts" log when I start VSCode:
2024-03-10 08:53:04.306 [info] ExtensionService#_doActivateExtension salesforce.salesforcedx-vscode-core, startup: false, activationEvent: 'onView:sfdx.tasks.view'

from salesforcedx-vscode.

@peternhale - lol, one other thing is that an .sfdx folder is magically created at the same time this error message shows up. I just downloaded a metadata package, unzipped, and opened in VSCode and I get the error (in my downloads folder) and then the sfdx folder is created.

This issue happens on 4 different computers, but I do have settings-sync so there must be something there.

These are the only user settings that seem related to this extension AFAIK

"salesforcedx-vscode-apex.java.home": "/Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home",
"settingsSync.ignoredSettings": ["salesforcedx-vscode-apex.java.home"],

from salesforcedx-vscode.