Missing `Content-Length` in headers may cause nginx 411 Length Required Error. about form-data HOT 8 CLOSED

Nothing special, this is my solution:

      var f = new formData()
      f.append('uploadfile', fs.createReadStream(file))
      f.append('formId', 1)
      f.getLength(function(err, length) {
        var token = qs.parse(url.parse(body.ErrMsg).query).token
        request.post({
            url: '/path/'
          , headers: {
              'content-length': length // 26xxxx
            }
        }, function(err, res, body) {
          var formId = body.match(/formId, '(\d+)'/)
          cb(err, formId && formId[1])
        })._form = f
      })

Here goes getLengthSync() version(wrong length)

      var f = new formData()
      f.append('uploadfile', fs.createReadStream(file))
      f.append('formId', 1)
      request.post({
          url: wx('/cgi-bin/uploadmaterial?cgi=uploadmaterial&type=0&t=iframe-uploadfile&lang=zh_CN&formId=1', token)
        , headers: {
            'content-length': f.getLengthSync() // 214
          }
      }, function(err, res, body) {
        var formId = body.match(/formId, '(\d+)'/)
        cb(err, formId && formId[1])
      })._form = f

from form-data.

So I checked at this request/request#396, seems this should be implemented by my own outside this library.

But still, getLengthSync() did not return the actual body length as I expected.

from form-data.

Can you show me piece of your code where you prepare data to send to the server and where you do submit? Thank you.

from form-data.

thank you @yyfrankyy, The same problem when uploading a file to my CMS on mochiweb server.

from form-data.

I'm not sure this is a bug, but content-length should be prepared in headers so that server knows when the chunk datas end.

No, it's not a bug. See:

http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.6.1

All HTTP/1.1 applications MUST be able to receive and decode the "chunked" transfer-coding, and MUST ignore chunk-extension extensions they do not understand.

That being said, I'm not against a patch that tries to determine and set the Content-Length for well known fixed size streams such as files. (However, this has to be done with great care and documentation - e.g. what happens if a file changes in size while uploading).

from form-data.

@felixge I think that should be documented with a sample. Content-Length can be set for certain number of cases by form-data, and that would be more reliable and save many other's time!

from form-data.

This is what we have in Readme:

Form-Data can recognize and fetch all the required information from common types of streams (fs.readStream, http.response and mikeal's request), for some other types of streams you'd need to provide "file"-related information manually, followed by example.

Although, I tested that behavior quite a bit and so far only node.js based server can accept chunked file uploads,
there are patches for couple Ruby standalone web server, but I haven't tried them yet.

So it's not a bug which collides with most implementations because they share common bug.

from form-data.

@yyfrankyy I updated Readme.

from form-data.