return request from .submit() about form-data HOT 8 CLOSED

Hm, seems like the request object needs the Content-Length in order be constructed. Since getting the value for that is async it can't be returned right away. Got an idea for a patch?

from form-data.

We can create request object before async call and return it and populate it later. But I was thinking that it's might be confusing to return httpRequest from FormData, since people might expect it to be same object.
Maybe we'll be better off just translating events.

@visionmedia How are you going track the progress on httpRequest?

from form-data.

unfortunate we can't initialize a node request to return (that I know of at least), emitting an event would be pretty weird, two callbacks is weird. I just wrote submit() with the progress stuff built in but im not sure what would be best in here. hmm yeah aside from an event or second callback I'm not sure

from form-data.

@alexindigo I'm just proxying the .write() to the request with this hack:

    var write = req.write;
    req.write = function(chunk){
      return write.call(this, chunk, function(){
        form.emit('progress', chunk, len);
      });
    };

and later using that to do the actual progress reporting. Maybe if we make that stuff into a little module and just do trackProgress(req).on('progress', re-emit crap here) we could add it to form-data :s haha, but no point turning it into another request library

from form-data.

How about?

if (params.request) {
  request = params.request;
} else {
  // https if specified, fallback to http in any other case
  if (params.protocol == 'https:') {
    // override default port
    if (!params.port) options.port = 443;
    request = https.request;
  } else {
    request = http.request;
  }
}

request = request(options);

then you can have your own augmented request instantiation function.

from form-data.

Oh, looks like we still can add content-length later:

"The header is still mutable using the setHeader(name, value), getHeader(name), removeHeader(name) API. The actual header will be sent along with the first data chunk or when closing the connection."

But, again, don't you think it will be confusing to return httpRequest from FormData.submit?

from form-data.

I think returning it is the most sensible thing personally, especially since it wont break anyone's apps since it's not returning this for chaining

from form-data.

@visionmedia @felixge Something like that.

from form-data.