formfu / catalyst-controller-html-formfu Goto Github PK

When use_hash_multivalue_in_request is activated for the Catalyst app, the request parameters are available only as a Hash::MultiValue. That makes $request->params->param('...') return only the first item when the parameter was set multiple times. Calling $form->process($c->req->params->as_hashref_mixed) seems to fix the problem.

Am I missing some option or is this really a bug? Then I would try to fix it.

as in https://rt.cpan.org/Ticket/Display.html?id=121792 --

The current release is problematic because it uses Test::Aggregate::Nested, which isn't compatible with new Test::More, which is bundled with the latest perl versions. I see you already made a change in git to remove Test::Aggregate (commit 646278c), but it is not yet released - please could this be released? many thanks!

I'm getting complaints from Debian's QA tool, lintian, that some modules have a NAME section that only contains the package name but no description (the part after the dash). I believe this is because some modules lack an ABSTRACT comment and thus weaver doesn't know what to do, and in some cases produces POD with two NAME sections even, like for HTML::FormFu::Element::RequestToken (version 2.04)

The affected modules are:

Catalyst::Controller::HTML::FormFu::Action::Form
Catalyst::Controller::HTML::FormFu::Action::FormConfig
Catalyst::Controller::HTML::FormFu::Action::FormMethod
Catalyst::Controller::HTML::FormFu::Action::MultiForm
Catalyst::Controller::HTML::FormFu::Action::MultiFormConfig
Catalyst::Controller::HTML::FormFu::Action::MultiFormMethod
Catalyst::Controller::HTML::FormFu::ActionBase::Form
Catalyst::Helper::HTML::FormFu
HTML::FormFu::Constraint::RequestToken
HTML::FormFu::Element::RequestToken
HTML::FormFu::Plugin::RequestToken

Please add ABSTRACT comments as appropriate.

MooseX::ChainedAccessors has been deprecated and its files moved into MooseX::Attribute::Chained; however Catalyst::Controller::HTML::FormFu still depends on it. This breaks the downstream Gentoo ebuilds as dev-perl/MooseX-ChainedAccessors-0.20.0 and dev-perl/MooseX-Attribute-Chained-1.0.1 try to manage the same files. Bug 434286 [1] filed to resolve the Gentoo dependencies, however if the module has been deprecated then Catalyst::Controller::HTML::FormFu should probably not use it.

[1] https://bugs.gentoo.org/show_bug.cgi?id=434286