Typescript autocomplete not working about formkit HOT 5 CLOSED

Unfortunately I dont think typescript is able to provide suggestions for discriminated unions (which the props are).

type Props = { type: 'text' } | { type: 'select' }

I would love to be wrong on this, but until there is enough data to narrow down which union is being used I dont think the ts lsp gives us much help.

from formkit.

I think the problem is not with discriminated unions, but with how the type works for inputs whose type is not specified.
I mean, the following:

_: {
    type? Props['type'] extends keyof FormKitInputProps<Props>
      ? never
      : Props['type']
    value ?: string
  }

should be

_: {
        type? Props['type'] extends keyof FormKitInputProps<Props>
          ? Props['type']
          : never
        value?: string
    }

We get a warning if the type is there, but it's empty. But if type is not specified, then type='text' is used by default.

This also works for custom input, as you can see in the screenshot there is a type "myRadio"

It works like this: if Props['type'] is a FormKitInputProps key, then FormKitInputType will be equal to Props['type']. Otherwise, FormKitInputType will be equal to never.
I could be wrong, correct me if I am.

from formkit.

Oh dang. thats awesome @Lol1chw! I would definitely accept a PR with these changes, that would be a great quality of life improvement.

from formkit.

@Lol1chw this is really close. You can see there is a slight unintended consequence here: https://github.com/formkit/formkit/actions/runs/8174587760/job/22349714133

Essentially by doing this:

  _: {
    type?: Props['type'] extends keyof FormKitInputProps<Props>
      ? never
      : Props['type']
    value?: string
  }

we’ve added a value type of string to all know input types since there are now 2 type unions that can match. So something the test checking that <FormKit type="file" value="abc" /> throws a ts error no longer passes (you can run these locally by doing a build and then running pnpm test typecheck).

from formkit.

Ok, I think I got this all working now.

from formkit.